From: Christian Hesse <mail@earthworm.de>
To: Sam Ravnborg <sam@ravnborg.org>
Subject: Re: build system: no module target ending with slash?
Date: Thu, 3 May 2007 09:17:15 +0200
User-Agent: KMail/1.9.6
Cc: linux-kernel@vger.kernel.org, James Ketrenos <jketreno@linux.intel.com>
References: <200705030043.49208.mail@earthworm.de> <20070503042511.GB12644@uranus.ravnborg.org> <20070503061533.GA13399@uranus.ravnborg.org>
In-Reply-To: <20070503061533.GA13399@uranus.ravnborg.org>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart1436080.j5VPoaYkFf";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200705030917.19630.mail@earthworm.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2642
Lines: 78

--nextPart1436080.j5VPoaYkFf
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Thursday 03 May 2007, Sam Ravnborg wrote:
> On Thu, May 03, 2007 at 06:25:11AM +0200, Sam Ravnborg wrote:
> > On Thu, May 03, 2007 at 12:43:43AM +0200, Christian Hesse wrote:
> > > Hi James, hi everybody,
> > >
> > > playing with iwlwifi I try to patch it into the kernel and to build it
> > > from there. But I have a problem with the build system.
> > >
> > > The file drivers/net/wireless/mac80211/Makefile contains one single
> > > line:
> > >
> > > obj-$(CONFIG_IWLWIFI)   +=3D iwlwifi/
> > >
> > > When CONFIG_IWLWIFI=3Dm in scripts/Makefile.lib line 29 the target is
> > > filtered as it ends with a slash. That results in
> > > drivers/net/wireless/mac80211/built-in.o not being built and the build
> > > process breaks with an error. What is the correct way to handle this?
> > > Why are targets ending with a slash filtered?
> >
> > Looks buggy. I will take a look tonight.
>
> After some coffee...
>
> Line 29 in Kbuild.include find all modules and a directory is not a modul=
e.
> In line 26 in same file the directory iwlwifi is included in the list
> of directories to visit.
> So there is something else going on.

In scripts/Kbuild.include line 26 is empty and line 29 is a comment... Do I=
=20
look at the wrong place?

I still believe in my version: built-in.o is built if any of $(obj-y) $(obj=
=2Dm)=20
$(obj-n) $(obj-) $(lib-target) contains anything in scripts/Makefile.build=
=20
line 77. As scripts/Makefile.lib line 29 filters the only target the object=
=20
file is not built.

> Anywhere I can get access to the combined source or could you try to post
> the full Makefile.

I just generated a patch [0] against vanilla 2.6.21 with latest mac80211 an=
d=20
iwlwifi from git. Get my config [1] and you should get my error.

[0] http://www.eworm.de/tmp/iwlwifi.patch.bz2
[1] http://www.eworm.de/tmp/config-iwlwifi-2.6.21
=2D-=20
Regards,
Chris

--nextPart1436080.j5VPoaYkFf
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBGOYx/lZfG2c8gdSURAkYjAKDG75pXRnxXENwm3zABew0UlJ0GewCbBNu9
9InQdHqNOY3/v5YhbExRWHg=
=2g6C
-----END PGP SIGNATURE-----

--nextPart1436080.j5VPoaYkFf--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/