Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c84b5ec0-0193-ab62-1985-25bc2baa9f05@linaro.org>
Date:   Sat, 9 Apr 2022 15:13:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 05/18] MIPS: DTS: jz4780: fix pinctrl as reported by
 dtbscheck
Content-Language: en-US
To:     "H. Nikolaus Schaller" <hns@goldelico.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
References: <cover.1649443080.git.hns@goldelico.com>
 <1941bc4ed553b27f399ad00ea61ff2b0237d14e3.1649443080.git.hns@goldelico.com>
 <e905896e-335d-a88a-1961-d17b92e46585@linaro.org>
 <530E0F7F-FC03-45DD-BF87-D049D3108AD3@goldelico.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <530E0F7F-FC03-45DD-BF87-D049D3108AD3@goldelico.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/04/2022 15:04, H. Nikolaus Schaller wrote:
> 
> 
>> Am 09.04.2022 um 13:13 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>:
>>
>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>> arch/mips/boot/dts/ingenic/ci20.dtb: pin-controller@10010000: $nodename:0: 'pin-controller@10010000' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
>>> 	From schema: Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml
>>>
>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>> ---
>>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> index 5f44cf004d473..b5299eaffb84a 100644
>>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> @@ -155,7 +155,7 @@ rtc_dev: rtc@10003000 {
>>> 		clock-names = "rtc";
>>> 	};
>>>
>>> -	pinctrl: pin-controller@10010000 {
>>> +	pinctrl: pinctrl@10010000 {
>>
>> Do it once for all DTSes, not one file at a time. There are four more
>> places with this.
> 
> Well, automation has no notion of "similarity" in this case to
> merge several patches.

What does that mean? One cannot create multiple patches and apply them?

> And they are not related. Every one is based on a different .yaml
> schema file.

Which does not matter, because the name of the node does not matter. We
enforce it in schema to makes things organized and easier in testing.
This does not fix any real problem, just the problem we created by
ourselves with schema.

> 
> That in all cases the result looks similar comes from similar
> requirements by the schemata and has no inherent connection.

All schemas will require it, won't they? The same for arm...

Best regards,
Krzysztof