Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a4f7d456-45d7-b461-6744-7c580ae94556@linaro.org>
Date:   Sat, 9 Apr 2022 13:20:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 15/18] MIPS: DTS: CI20: fix fixed regulators as reported
 by dtbscheck
Content-Language: en-US
To:     "H. Nikolaus Schaller" <hns@goldelico.com>,
        Rob Herring <robh+dt@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
References: <cover.1649443080.git.hns@goldelico.com>
 <f04ba92a958abe0051be7ce3202f6361cb0f05f2.1649443080.git.hns@goldelico.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <f04ba92a958abe0051be7ce3202f6361cb0f05f2.1649443080.git.hns@goldelico.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
> arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@0: 'anyOf' conditional failed, one must be fixed:
> 	'reg' is a required property
> 	'ranges' is a required property
> 	From schema: python/site-packages/dtschema/schemas/root-node.yaml
> arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@1: 'anyOf' conditional failed, one must be fixed:
> 	'reg' is a required property
> 	'ranges' is a required property
> 	From schema: python/site-packages/dtschema/schemas/root-node.yaml
> arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@2: 'anyOf' conditional failed, one must be fixed:
> 	'reg' is a required property
> 	'ranges' is a required property
> 	From schema: python/site-packages/dtschema/schemas/root-node.yaml
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> index cb5257d32b55e..c045c4f75895e 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -69,7 +69,7 @@ led3 {
>  		};
>  	};
>  
> -	eth0_power: fixedregulator@0 {
> +	eth0_power: eth3v3 {

No, Devicetree spec requires generic node name, so "regulator-0" is
appropriate. See also examples of device tree node names in the spec.
"eth3v3" is a specific one, not generic.


Best regards,
Krzysztof