Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ea594b7a-22d5-ba39-6e83-921f98fa76a5@infradead.org>
Date:   Sat, 9 Apr 2022 08:11:37 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] sparc: cacheflush_32.h needs <linux/mm.h>
Content-Language: en-US
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        sparclinux@vger.kernel.org
References: <20220409060215.19890-1-rdunlap@infradead.org>
 <YlE54Cs0mi0WDPo7@ravnborg.org>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <YlE54Cs0mi0WDPo7@ravnborg.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/9/22 00:46, Sam Ravnborg wrote:
> Hi Randy,
> 
> On Fri, Apr 08, 2022 at 11:02:15PM -0700, Randy Dunlap wrote:
>> Add <linux/mm.h> to cacheflush_32.h just as in cacheflush_64.h.
> 
> Just add a forward declaration like this to fix it:
> 
> struct page;
> 
> No need to pull in a header file when a forward is enough.

Sure, will do.

> Maybe we could simplify sparc64 in a similar way, but that is another
> patch and it may require extra work in other files anyway.
> 
> 	Sam

-- 
~Randy