Received: by 2002:a05:6a10:87d6:0:0:0:0 with SMTP id g22csp843106pxr; Mon, 11 Apr 2022 08:32:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwV8/WocueDbAOtdodNHTIJQXNcQTCzcemGw7jgCnAKoqivamlhaHRQKa2D2lclPm/Yn1VK X-Received: by 2002:a17:907:2d93:b0:6e8:9838:339c with SMTP id gt19-20020a1709072d9300b006e89838339cmr3657604ejc.655.1649691149892; Mon, 11 Apr 2022 08:32:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649691149; cv=none; d=google.com; s=arc-20160816; b=z0hOelTDLMJiO98a/hOGGSuZKcIOjasK/qxtloQePTcMFt+Wsw+QOob8Y1v1d34ReS arEWentLxCejNRaWYc4YXp+qDZZi7ajTuTFJ4mGHO3NlKJGIvXOuqRVIso5i6ZcNThNj miUdlo4V7+BSRA7aQaINzwov9GyDrVgL49XFSekF9tRVTstOhjeuUVOlon08/BIEEop8 f0b9F6QIRkpVleFCeGEtfTummFTrHl5VK93qvX0Gs5kBeHq/vpDVvedoOsDXImmaPDQL dTZQuMi3rJLEO0SKv2p7xx7nDnT8LrTPhk6waXfBiWLx9PXJj9yAQ5+ekL23NtZ1nnFQ N+Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=L3D5twS6fI8upjNFbaq7L4RyTo/YSaqC5qUAqNUSSRk=; b=dMJydqpBHyTrPBqzve3Jqep9BloKRBbrYpShl7YXe9auLkaIyoUrpQRKh5oEdjcrZE S2i5aOTuXy0ZEA6LaDW90ZzqaFkpw9FqbNxQmnwrHKrAsCoOeoNpzOSoYHktI2UYwhlD JGvDda6/PSFeyWOcJS9PJlxsMbJvGPDkCHR4y/HVqbIm6tQ100iawtC3jE92Q5zQBNLk 7royxXODuXzo1jR8JV9OPm2xR5P3S0AlK6JsG/LxX7GUy1FGOL6pwCrP/pEsFUXaNCBc oQXJGOxM09UxxmNXtE1sQDdP0dZXCLDDi2XMKN16G1wq5Fys+2zrmFz6J8RKn3aeRhZ1 9XNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YpgNpxYy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y10-20020a17090614ca00b006e88e3e54eesi2829964ejc.398.2022.04.11.08.32.02; Mon, 11 Apr 2022 08:32:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YpgNpxYy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238214AbiDKMq5 (ORCPT + 99 others); Mon, 11 Apr 2022 08:46:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236431AbiDKMq4 (ORCPT ); Mon, 11 Apr 2022 08:46:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B1E4015FDE for ; Mon, 11 Apr 2022 05:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649681081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L3D5twS6fI8upjNFbaq7L4RyTo/YSaqC5qUAqNUSSRk=; b=YpgNpxYy1mbkRVy/O2dnDrMJHb7EoggFM2YOQsnpnHanH608Nom2joR+0ZsRXik8zMHMA1 Rlp4D+5LwYrydehgKWBlaWeLR2nD9uCIn9wJDMijIkn3/WUjQHFORz/f6/d08REvtdUyjB +IHpKY8ZqgeMOo57motIm4iwq+Uqb5w= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-488-xIvNM0C2OXKCHP56sbKC7w-1; Mon, 11 Apr 2022 08:44:38 -0400 X-MC-Unique: xIvNM0C2OXKCHP56sbKC7w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 546293802AC2; Mon, 11 Apr 2022 12:44:37 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF59C40CFD0F; Mon, 11 Apr 2022 12:44:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220406075612.60298-6-jefflexu@linux.alibaba.com> References: <20220406075612.60298-6-jefflexu@linux.alibaba.com> <20220406075612.60298-1-jefflexu@linux.alibaba.com> To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com Subject: Re: [PATCH v8 05/20] cachefiles: implement on-demand read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1091904.1649681074.1@warthog.procyon.org.uk> Date: Mon, 11 Apr 2022 13:44:34 +0100 Message-ID: <1091905.1649681074@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeffle Xu wrote: > /* > * Uninstall anon_fd to the cachefiles object, so that no further > * associated requests will get enqueued. > */ "Uninstall anon_fd from..."? > +static int init_read_req(struct cachefiles_req *req, void *private) Prefix with "cachefiles_" please (or "cachefiles_ondemand_"). David