Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Apr 2022 16:51:54 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: core: Start managing serial controllers to
 enable runtime PM
Message-ID: <YlQyeoCdTtfUc45h@atomide.com>
References: <20220411120218.17422-1-tony@atomide.com>
 <YlQsTWcM3is9TGdw@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YlQsTWcM3is9TGdw@smile.fi.intel.com>
Precedence: bulk

* Andy Shevchenko <andriy.shevchenko@intel.com> [220411 13:26]:
> On Mon, Apr 11, 2022 at 03:02:18PM +0300, Tony Lindgren wrote:
> > +struct serial_controller {
> > +	struct uart_driver *drv;		/* For port specific uart_state */
> 
> > +	struct mutex lock;			/* For changing enabled_count */
> > +	int enabled_count;			/* Enable count for runtime PM */
> 
> Wondering if we may use kref instead which will check for saturation as well.

Thanks for the quick review, using kref is a good idea.

Regards,

Tony