Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Apr 2022 16:12:08 -0500
From:   Rob Herring <robh@kernel.org>
To:     Philipp Zabel <p.zabel@pengutronix.de>
Cc:     devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        linux-kernel@vger.kernel.org,
        Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Subject: Re: [PATCH 10/14] dt-bindings: reset: snps,hsdk-reset: Convert to
 yaml
Message-ID: <YlClKKHnTwsNUayj@robh.at.kernel.org>
References: <20220407154338.4190674-1-p.zabel@pengutronix.de>
 <20220407154338.4190674-10-p.zabel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220407154338.4190674-10-p.zabel@pengutronix.de>
Precedence: bulk

On Thu, Apr 07, 2022 at 05:43:34PM +0200, Philipp Zabel wrote:
> Convert the device tree bindings for the Synopsys HSDK reset controller
> to YAML schema to allow participating in DT validation.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
>  .../bindings/reset/snps,hsdk-reset.txt        | 28 -----------
>  .../bindings/reset/snps,hsdk-reset.yaml       | 47 +++++++++++++++++++
>  2 files changed, 47 insertions(+), 28 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/reset/snps,hsdk-reset.txt
>  create mode 100644 Documentation/devicetree/bindings/reset/snps,hsdk-reset.yaml
> 
> diff --git a/Documentation/devicetree/bindings/reset/snps,hsdk-reset.txt b/Documentation/devicetree/bindings/reset/snps,hsdk-reset.txt
> deleted file mode 100644
> index 830069b1c37c..000000000000
> --- a/Documentation/devicetree/bindings/reset/snps,hsdk-reset.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Binding for the Synopsys HSDK reset controller
> -
> -This binding uses the common reset binding[1].
> -
> -[1] Documentation/devicetree/bindings/reset/reset.txt
> -
> -Required properties:
> -- compatible: should be "snps,hsdk-reset".
> -- reg: should always contain 2 pairs address - length: first for reset
> -  configuration register and second for corresponding SW reset and status bits
> -  register.
> -- #reset-cells: from common reset binding; Should always be set to 1.
> -
> -Example:
> -	reset: reset@880 {
> -		compatible = "snps,hsdk-reset";
> -		#reset-cells = <1>;
> -		reg = <0x8A0 0x4>, <0xFF0 0x4>;
> -	};
> -
> -Specifying reset lines connected to IP modules:
> -	ethernet@.... {
> -		....
> -		resets = <&reset HSDK_V1_ETH_RESET>;
> -		....
> -	};
> -
> -The index could be found in <dt-bindings/reset/snps,hsdk-reset.h>
> diff --git a/Documentation/devicetree/bindings/reset/snps,hsdk-reset.yaml b/Documentation/devicetree/bindings/reset/snps,hsdk-reset.yaml
> new file mode 100644
> index 000000000000..a7cb5580c070
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/snps,hsdk-reset.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/snps,hsdk-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synopsys HSDK reset controller
> +
> +maintainers:
> +  - Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> +
> +properties:
> +  compatible:
> +    const: snps,hsdk-reset
> +
> +  reg:
> +    minItems: 2
> +    maxItems: 2
> +    description: |
> +      Should always contain 2 pairs address - length: first for reset
> +      configuration register and second for corresponding SW reset and status
> +      bits register.

items:
  - description: reset configuration register
  - description: corresponding SW reset and status bits register


> +
> +  '#reset-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/reset/snps,hsdk-reset.h>
> +
> +    reset: reset@880 {
> +        compatible = "snps,hsdk-reset";
> +        #reset-cells = <1>;
> +        reg = <0x8A0 0x4>, <0xFF0 0x4>;
> +    };
> +
> +    // Specifying reset lines connected to IP modules:
> +    ethernet {
> +        resets = <&reset HSDK_ETH_RESET>;
> +    };

No need to show the consumer side in every provider. Please drop.

Rob