Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: eCB+57LlV2F1zSToMPkTVU5Sokwf8CqMUosAWmg/uVsoIglfunOCy+9vjOn3E4Q0o/LkDFikIT
 vtQNuTyV6hJsv+298ekentwETaZQlk6WBtFTX6UypeLXJ6Um3sxJJSvJUi8t9KyDihzN5BS98y
 nBa8ZT0Yj7Kag36DH1j2b7lO1iF8aavKj36oUhc2eC0hKlPJRiBNtim0EkPHnTzTARvuc8xX14
 cJhiHRAG5FpHAAivriKv1eW2xofM0DpDIptxhK/uy53opUaWEh1Wenb4O4TanTb6035i/PXGml
 yi/O7wg7az2jynSgkP0FCBun
IronPort-SDR: +Ce5avOs1UQeWc852eOj9M93dDE5rfhylO6C6MtjclC90RAvpXjLQleJ/DPDuYA4HsR0lqka48
 cDFynTKiI+UiaoFlIip9iMEjuOQbARpl2NzHj/9NNBgvxV3ddq9tuE90rZ9N676A5Q2VvZCCC8
 YcbOag7zUEyfX9jV6nB81VuZZJir1M9IzruDOX3ByIkHZxe39jPeJAlZH6ydUt6xmUMELXpRC9
 yiqD+Qhl0BtN7+VNg/Z1rRJWH2B5UBN0NJqUMITNwFhoEQasiNHFHYxr/Ns+8qEk1YzKuxNhSH
 mak=
WDCIronportException: Internal
Message-ID: <58553b08-3c58-a4c8-a402-26d036ef0640@opensource.wdc.com>
Date:   Mon, 11 Apr 2022 21:26:18 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4] libata: Improve ATA queued command allocation
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, hch@lst.de
Cc:     linux-doc@vger.kernel.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1649408652-217372-1-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1649408652-217372-1-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/8/22 18:04, John Garry wrote:
> Improve ATA queued command allocation as follows:
> 
> - For attaining a qc tag for a SAS host we need to allocate a bit in
>   ata_port.sas_tag_allocated bitmap.
> 
>   However we already have a unique tag per device in range
>   [0, ATA_MAX_QUEUE -1] in the scsi cmnd budget token, so just use that
>   instead.
> 
> - It is a bit pointless to have ata_qc_new_init() in libata-core.c since it
>   pokes scsi internals, so inline it in ata_scsi_qc_new() (in
>   libata-scsi.c). Also update Doc accordingly.
> 
> - Use standard SCSI helpers set_host_byte() and set_status_byte() in
>   ata_scsi_qc_new().
> 
> Christoph Hellwig originally contributed the change to inline
> ata_qc_new_init().
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Applied to for-5.19. Thanks !

-- 
Damien Le Moal
Western Digital Research