Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <550e04f5-acd9-e50a-1aae-4e639951e35e@linaro.org>
Date:   Sun, 10 Apr 2022 10:50:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] dt-bindings: firmware: convert Qualcomm SCM binding to
 the yaml
Content-Language: en-US
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        David Heidelberg <david@ixit.cz>
Cc:     Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        ~okias/devicetree@lists.sr.ht, Andy Gross <andy.gross@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211218194038.26913-1-david@ixit.cz>
 <YfhT/ltPDhQZV0Bo@builder.lan>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <YfhT/ltPDhQZV0Bo@builder.lan>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 31/01/2022 22:26, Bjorn Andersson wrote:
> On Sat 18 Dec 13:40 CST 2021, David Heidelberg wrote:
> 
>> Convert Qualcomm SCM firmware binding to the yaml format.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> This patch comes with followup question -> since not all definitions
>> follow `"qcom,scm-*chipset*", "qcom,scm"`, should I change them or adjust this
>> binding to cover all cases?
>>
> 
> I don't remember why some platforms has the generic "fallback" and
> others doesn't. I don't have any objections to defining the binding as
> you've done.

Looking at the driver it seems that there some differences between
certain versions and generic qcom,scm. For example they require bus
clock which could mean they won't work without it on a "qcom,scm"
compatible. That could mean that original "qcom,scm" also required that
bus clock but it was for example always enabled. Or that clock was never
needed on "qcom,scm".

I think this should be converted without generic fallback, IOW, the
original bindings are not accurate and driver+DTS are better hints how
it should work.


Best regards,
Krzysztof