Received: by 2002:a05:6a10:87d6:0:0:0:0 with SMTP id g22csp990209pxr; Mon, 11 Apr 2022 12:08:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaZbLFV1dSxSnHfH5KNgDrk5XNB5o9jjQEdDVsIyVOwEVfRxw6iDEsEZ3k0wUcspKGQ8CK X-Received: by 2002:a17:906:58c7:b0:6e8:3ceb:58e7 with SMTP id e7-20020a17090658c700b006e83ceb58e7mr20648575ejs.384.1649704087885; Mon, 11 Apr 2022 12:08:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649704087; cv=none; d=google.com; s=arc-20160816; b=nbP6ep/oqKMAKlfEu2rH+xHbPilCgayK30oXiTrXWeiBfqCpYuTXhQ+XXntDavvvoF 9RoKWyJk8eyrqv++I19QKLDo44xgkrxoGOx4xqnflWMXOzlZ/1DrPUTKXoTGMgtAYAhQ Jy56x3YDhUkD9Wo0DEV2kX4C7DJhrxYNl90ZnknGwX63Twjt/Vdqp9/VMAwILgQaCfTH JKMNj2a0OYdL+n5mXMkD7F77J74kvjYWCvNdFCTszNOvuNm/QGdQv0onqpfxQ7VhMhlB K+Y6/wAh5Y1poCh9yJbrvHZGI229/Z30UNFQq29w6KR02MvqA55PbIOdbzNUKHt/nGu+ peeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=DQSDiqqXCwGrfnlhVZaZHHjASsZ2W67eRClqnZKjpvo=; b=y0uUdDXqcgDzjEkLRB19CsYkd/KUIuu+clT6KJbixD+zT8cg1/yATVFLKQ4ugPsJSS gcdxljoTR0821S4tC6SSKzqTH9ODbIXGRYVPcQeMH37diLfTeFYujD06H57SDz4O/6Ys rO0DC7gKFj+u+Oa7j2+6/L6Regrmx0plhYWQuzr81DIV6kHJ5bukj8LJ/Dtel6QswWRl 91TyjT6dKgoyxLrwyUQoXeUkq6S9KUc55+PkpR0V8+ep1YBrAXI8G4fZBUNv6u7H8jBw 5e1gg92kZr36eb7ikZPPErDgjyla3kBTHLo8QacwOiqn5gmkuUHINZEthcB4pbqThLt7 +KRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="l83H0X/K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l21-20020a170906079500b006e8896e1733si3417904ejc.760.2022.04.11.12.07.42; Mon, 11 Apr 2022 12:08:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="l83H0X/K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343966AbiDKI6U (ORCPT + 99 others); Mon, 11 Apr 2022 04:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344117AbiDKI6L (ORCPT ); Mon, 11 Apr 2022 04:58:11 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0E271D328; Mon, 11 Apr 2022 01:55:57 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 89C741F42DB8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649667356; bh=6eM5QaDtwIp81r/ywmhqNWM0S8ebBuPxIDRHQ0pR/n0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=l83H0X/KHAtu0rwTlcbBW8wYWAVHPqo+kmkE4Q5qUSDrFD66vNkwLzl4ftYvooe+P Y21W0NK4vsVl9jetFQDoSUSIpvkAlY8YGMnCGnjaWSQTeDt5CcuCR7clPb+maI/NZR Swx2eQO2mprdEIWy5T3xXDwLgr2qlKXXJ8MOpUx9zcCHXG6cGkFlXI4IyVs8wvHE7Z 1yv+DyaZcAAzzJItButc02SQ4NWOKoSBNxqmXo8kbKsiDLEWlFIOtSo0IEgV9yEhvQ 0ZSy9rRYK1CjjeMjF/fA7IgnuY2z1Jsp29xFr0EUThJvh/BRn8xuXf4a53ioeMRDTS 9/ocGOf2lI1hw== Message-ID: <34c30f7c-70e2-dc95-a664-9379f91f5aed@collabora.com> Date: Mon, 11 Apr 2022 10:55:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] remoteproc: mtk_scp: Fix a potential double free Content-Language: en-US To: Christophe JAILLET , Bjorn Andersson , Mathieu Poirier , Matthias Brugger Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <1d15023b4afb94591435c48482fe1276411b9a07.1648981531.git.christophe.jaillet@wanadoo.fr> From: AngeloGioacchino Del Regno In-Reply-To: <1d15023b4afb94591435c48482fe1276411b9a07.1648981531.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 09/04/22 08:27, Christophe JAILLET ha scritto: > 'scp->rproc' is allocated using devm_rproc_alloc(), so there is no need > to free it explicitly in the remove function. > > Fixes: c1407ac1099a ("remoteproc: mtk_scp: Use devm variant of rproc_alloc()") > Signed-off-by: Christophe JAILLET Reviewed-by: AngeloGioacchino Del Regno