Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 13/18] dt-bindings: fix jz4780-nemc issue as reported by
 dtbscheck
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <036b66b2-c221-6e9e-6a56-510e7a0d20d3@linaro.org>
Date:   Sat, 9 Apr 2022 15:09:19 +0200
Cc:     Rob Herring <robh+dt@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <B9FD64FE-82B0-4DC2-B4C3-BE266DAB28A0@goldelico.com>
References: <cover.1649443080.git.hns@goldelico.com>
 <84adfe6237cd4cfd52cb9723416f69926e556e55.1649443080.git.hns@goldelico.com>
 <036b66b2-c221-6e9e-6a56-510e7a0d20d3@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> Am 09.04.2022 um 13:26 schrieb Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org>:
>=20
> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>> jz4780-nemc needs to be compatible to simple-mfd as well or we get
>>=20
>> arch/mips/boot/dts/ingenic/ci20.dtb: memory-controller@13410000: =
compatible: 'oneOf' conditional failed, one must be fixed:
>> 	['ingenic,jz4780-nemc', 'simple-mfd'] is too long
>> 	'ingenic,jz4725b-nemc' was expected
>> 	'ingenic,jz4740-nemc' was expected
>> 	=46rom schema: =
Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>>=20
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> .../devicetree/bindings/memory-controllers/ingenic,nemc.yaml    | 2 =
+-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git =
a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml =
b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>> index 24f9e19820282..3b1116588de3d 100644
>> --- =
a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>> +++ =
b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>> @@ -17,7 +17,7 @@ properties:
>>     oneOf:
>>       - enum:
>>           -=20
>> -          - ingenic,jz4780-nemc
>> +          - [ , simple-mfd ]
>=20
> This is not correct representation. If you really need simple-mfd, =
then
> this should be a separate item below oneOf.

Well, it is valid YAML syntax and seems to be accepted by dtbscheck.

> The true question is whether you need simple-mfd. Isn't the binding =
(and
> the driver) expected to instantiate its children?

I had expected that but current ingenic,jz4780-nemc code doesn't.

Everything is explained in 190607f2d59e174bcf8415efb1bb390737f8d428

But if someone writes a fix for the ingenic,jz4740-nemc driever
we can of course live without this patch. And partially revert
190607f2d59e174bcf8415efb1bb390737f8d428