Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Apr 2022 11:06:23 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Vihas Makwana <makvihas@gmail.com>
Cc:     Joe Perches <joe@perches.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Pavel Skripkin <paskripkin@gmail.com>
Subject: Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper
 rtw_free_cmd_priv
Message-ID: <20220411080623.GB12805@kadam>
References: <20220410163117.3964-1-makvihas@gmail.com>
 <20220410163117.3964-2-makvihas@gmail.com>
 <783d850ce7778e9d8f203155034e432910553b1b.camel@perches.com>
 <CAH1kMwTPkPV=gLg38m=yq=n1U2Mqa4+1XNtB_5Kc2y7O0mpMpQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH1kMwTPkPV=gLg38m=yq=n1U2Mqa4+1XNtB_5Kc2y7O0mpMpQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q37i9PORp2IQ1a1Yxsv84JTdwv5QjwUhJyixuLztDCmxRnfrWndXgQ61+ZY/?=
 =?us-ascii?Q?wd8WKSFoUzHYan/V3+On6tqH7d8C5mGOD0i/ZCXTiMQpNazoPc57oFzyW6kM?=
 =?us-ascii?Q?qPTq7e7b9b4Lsue11y02T6fiflhy/Vg3GmtyePfURQ6R6siGv1dOlVjr69Ov?=
 =?us-ascii?Q?2MD8jhLrrUF7TlUUuyLKDvx8zraJZEzmKa6JDK7sj9mxsgSTABw7J+IBSYG5?=
 =?us-ascii?Q?t8wb31Eh467MwZTLVqjS85Ptf3dMUm0qNCMQhLM5M6uDcpvQmg94Slb1mxx9?=
 =?us-ascii?Q?gJbJl39Ygt9+v6pI27Evw5U4X3Rfsp81K7blVYpHgZ4zvJQ+jToAVWy9PQfL?=
 =?us-ascii?Q?77arcrFpiQcaUluV9PFMIF3vZyAMZRYkjlxC44lU+LmWNpWqSlRYbAaj0wLe?=
 =?us-ascii?Q?LIrarKAbVqwm/dRD5Hp4NfajbyK+e+qYo7yaOYiC4zVFIb1dDqAHNlIda54I?=
 =?us-ascii?Q?gM5ElOwZyztEpMibCHGJuQvucrjpQ5madNX9lXHZV63WbGOFqgLTqCw5i1gd?=
 =?us-ascii?Q?0jK2ks2KDhPWCoxzMMhxGXoI4Ys3wPKxt9Hjt9YEw9QBbTCzgSmUj7+oJ3bH?=
 =?us-ascii?Q?coMtRmpVOCBTKx1C2ltDG1JIUyt11wTL9o40XFCziYeRk+G/vS97Esr1yEqc?=
 =?us-ascii?Q?WRqz6fTQK8Ufd49do14Vg+P6jeBtUyH4WV8tOqmo5gagx0ni2k9lHqDry5Cf?=
 =?us-ascii?Q?138Hb8+sxY+bE2q9zT8uDpvMkjR1AfqrEA4jnyiGfrHCO/I0B8ImHtO+xAUo?=
 =?us-ascii?Q?T99XO8gW/3pDbSVq1yH/keGWMOE3RkG5N5XWOqW1b8jVzpgXytq7ZQHPea6f?=
 =?us-ascii?Q?CEq7TlnucSP8paqR9VfgA3z6ZGHiniXLZIcCq+LbSCKkcbCjBkE3nmuu2S/n?=
 =?us-ascii?Q?oc1pOubp0tTeZli6gFmK2zyw52+BqWNZCjNs1RZoy+kB1QDUd3/3mc70y0bx?=
 =?us-ascii?Q?bwSJhnyRfAztJmptPlYApnlMQUdsMx1RqPxspzS0bMuqWYdGHJ7P5A+01W1x?=
 =?us-ascii?Q?Jadf8Ak955rEx8hFfGChxesruimI0cbtRgXzRLWbOLX2UowCO/T+mR5D1gPR?=
 =?us-ascii?Q?sq/9reC3opgmSDgDpxkJ81fn4nu9ln9qZSUIs6Yjt2LKG34A4gIb2d43sMyC?=
 =?us-ascii?Q?TCTQxE3/V8TxoE3cf1ln97E1u9tkn2sDyExu4SfXEQOQsEq15b2TUzS8rjwG?=
 =?us-ascii?Q?IQ9RYlUh4YFAJyLY3pIQaA1hbmvUHA7U69zliu1dreaJ1rICQoz3a3A2NubA?=
 =?us-ascii?Q?2RZJ0HNeiXxc5CQUiCuCkv4B+jNDMWA4mEp0ypO+aG2j+FNv0Yd38lkGBJVi?=
 =?us-ascii?Q?K4+f8y/lxFASRUPzhDE+l11u7osmqO0FZ2fwGts5pQh/RNyoaolFak63v2vB?=
 =?us-ascii?Q?KQUm7aN8b0gWho2y7lfGU1ymqccCKDPuQPlIu9YHVJRoNKe8pZGsPJXFISZ6?=
 =?us-ascii?Q?asxp6FLtL3pTFourr0V66uq6ed/a8Ur2ycpQdL6rp5+YyCSzFg/d2sXkx+/3?=
 =?us-ascii?Q?9d7QpsupqptCKgKHmHo00hzcuGGPlPAsLv3JR9dXkkUA6xtrAH6monkumRnk?=
 =?us-ascii?Q?stV/3kxctN8xNWd0MjXNYjdckO6Uwo3orb6xuxxgr/vj+jTkVUafMWTJumOm?=
 =?us-ascii?Q?2D6dQVgb29W/QRkozenNjQjPRAOOvbmyqBAYa+OdWLI54tgbfJwLt5AZXvVG?=
 =?us-ascii?Q?XLNH5TdaefWb/UgN3R053D5XtX1MBwGa8IfxfwKXNm+fZSj21ZUduSg0MfsE?=
 =?us-ascii?Q?7sVfrHIUAvXHPd+RjHjD7bXVqBQ2Bbo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a51bf6e7-1313-4010-eb3e-08da1b92384e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 08:06:45.4436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zZP88WLjg79gfSWDHjJcc12qHk40Xn3bbmJMQe3wq0TvDG5/S+c4qX1z70p/pk/edRpvQ1hRLKdE4/LCZJQ8gryE4MBVrT/DutxeisMfutQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4832
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.858
 definitions=2022-04-11_02:2022-04-08,2022-04-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=842
 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204110045
X-Proofpoint-ORIG-GUID: 5Pjo6Mha_zrXsFyv4CR8qs9c_gjLyFsk
X-Proofpoint-GUID: 5Pjo6Mha_zrXsFyv4CR8qs9c_gjLyFsk
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 10, 2022 at 11:08:02PM +0530, Vihas Makwana wrote:
> > On Sun, 2022-04-10 at 22:01 +0530, Vihas Makwana wrote:
> > > Remove the unnecessary wrapper. The logic of rtw_free_cmd_priv can
> > > be moved to _rtw_free_cmd_priv.
> >
> > If you are going to drop wrappers, my preference would be
> > to drop the underscore prefixed ones.
> >
> Yes, that was my initial thought too. But there are already some init
> and free functions in the module with underscores prefixed.
> So I didn't do it that way. Maybe the developers kept it that way for
> some reason.

Yeah, no.  There is no reason.  Get rid of the underscores.

regards,
dan carpenter