Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20190617144725.6415-1-geert+renesas@glider.be>
 <20190617160011.GB3927@kernel.org> <CAMuHMdWPDMhz9YdEs-=iCLa6w--iS-Ug9SMUa=UG0bW2mMYyxA@mail.gmail.com>
 <CO1PR11MB4803640A785DF199D0496017E8E49@CO1PR11MB4803.namprd11.prod.outlook.com>
 <70411972-e31a-27a1-acbf-26f5ab471a6a@linux.intel.com>
In-Reply-To: <70411972-e31a-27a1-acbf-26f5ab471a6a@linux.intel.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Sun, 10 Apr 2022 11:46:11 +0200
Message-ID: <CAMuHMdV8ROcNZ1o+uEa9s-VnZp2NZET7SFcX_+-K1RJa-UBCmQ@mail.gmail.com>
Subject: Re: [PATCH] perf: Add missing newline at end of file
To:     Xing Zhengjun <zhengjun.xing@linux.intel.com>
Cc:     "Liang, Kan" <kan.liang@intel.com>,
        Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andi Kleen <andi@firstfloor.org>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Zhengjun,

On Fri, Apr 8, 2022 at 4:45 PM Xing Zhengjun
<zhengjun.xing@linux.intel.com> wrote:
> On 4/5/2022 9:59 PM, Liang, Kan wrote:
> >> On Mon, Jun 17, 2019 at 6:00 PM Arnaldo Carvalho de Melo
> >> <arnaldo.melo@gmail.com> wrote:
> >>> Em Mon, Jun 17, 2019 at 04:47:25PM +0200, Geert Uytterhoeven escreveu:
> >>>> "git diff" says:
> >>>>
> >>>>      \ No newline at end of file
> >>>>
> >>>> after modifying the files.
> >>> Auto generated files, IIRC, Andi, Kan, Sukadev?
> >> The auto-generated files have been updated, the issue still exists.
> >>
> > It seems like a converter tool issue.
> >
> > + Zhengjun
> >
> > Zhengjun, could you please take a look?
> >
> > Thanks,
> > Kan
> It only happened for perf core event files. Add "\n" at the end of the
> perf core event file, then the issue is fixed.
> I have updated the event convert tool
> https://github.com/intel/event-converter-for-linux-perf , then the next
> time uses the convert tool to generate perf events, the issue will be
> disappeared.

Thanks a lot!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds