Received: by 2002:a05:6a10:87d6:0:0:0:0 with SMTP id g22csp1147234pxr; Mon, 11 Apr 2022 16:40:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxs+Pk4xYH73tbH/NpsBMRm4b/6/Kb2niyCjBw1hptylIk+0bg53vGqCtqGVEFv3hg/u1ZP X-Received: by 2002:aa7:cb8b:0:b0:410:9aaf:2974 with SMTP id r11-20020aa7cb8b000000b004109aaf2974mr35580804edt.173.1649720437465; Mon, 11 Apr 2022 16:40:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649720437; cv=none; d=google.com; s=arc-20160816; b=cPzSWXgnzDJL00x39rHH8LcdgvfCUeUu7NuBaLfrjeKMJFyj4o9gcPyGmXsJtoXoa1 6r1cB8OOfS3iMZcDIKgRhDs+LGuAF26jeniopCVhz9Xv+0+Pgdg/bQWs2EAoDTVo/jXM deoKuQCrRFgmTIZtXDsu+FLFlqiC9umkjPzczwrgUbdpX8MXvCXNEMLVGnPW364br4Nt WrRKwMdpl79gat3/WlnUJqXPYcwYbuki+qysBGa+cGLDvuzYFZZ6ioSGoi7IX5A5Xhfm SfIyK/rjukBxhJTx6tIex3xC3p7rHSOYOPm+6uWvqs19h/FVPiODTu2Msjep4py+uKzS Yyzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=+ogLUnEoauTcCKHTmgK+gz5LsCY63CVUycWSO2ISIy0=; b=YEsxFp4Oh15IGuVOhFFSn+g6XCJr9dnInvIPl8w33/zc5T/1pft/wURf6OffeuMHyO iNPsoeGQwLMTb8MHr/hzbumM+XqVGWPFXZaPMP4Co4twIPN+EsaeE4vvqnid4g/OSPz8 LzeHK/gFweCvRzxo7MqNkzV9NuLrYm8ZmmdSdXMcpsMVGSaHNxeAyeIikhufZPLqKwTi HrvP/ZNOQ7oPR5XnoHh1eMPc1LIljwNUUpKIbj7t3OPk8PAXeP5dIKSOe4Ve0lUOfqV1 Br0UILAg1xvxW05LNddEYaFjJtMzHEO5a/awLOR1y6js5Zx3Bw7sb/nZje9Oupg+N4AQ k3ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rs19-20020a170907037300b006e88c4b7de3si3795358ejb.912.2022.04.11.16.40.12; Mon, 11 Apr 2022 16:40:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346152AbiDKMcZ (ORCPT + 99 others); Mon, 11 Apr 2022 08:32:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346094AbiDKMcO (ORCPT ); Mon, 11 Apr 2022 08:32:14 -0400 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 170233EBB9; Mon, 11 Apr 2022 05:29:58 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0V9pDkdH_1649680193; Received: from 30.225.24.83(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V9pDkdH_1649680193) by smtp.aliyun-inc.com(127.0.0.1); Mon, 11 Apr 2022 20:29:55 +0800 Message-ID: <8aef9756-9a71-de36-d5b7-e9c32156afa3@linux.alibaba.com> Date: Mon, 11 Apr 2022 20:29:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v8 02/20] cachefiles: extract write routine Content-Language: en-US To: David Howells Cc: linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com References: <20220406075612.60298-3-jefflexu@linux.alibaba.com> <20220406075612.60298-1-jefflexu@linux.alibaba.com> <1090420.1649679186@warthog.procyon.org.uk> From: JeffleXu In-Reply-To: <1090420.1649679186@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/11/22 8:13 PM, David Howells wrote: > Jeffle Xu wrote: > >> It is worth nothing that, ki->inval_counter is not initialized after >> this cleanup. > > I think you meant "It is worth noting that, ...". Yeah... > > Btw, is there a particular reason that you didn't want to pass in a pointer to > a netfs_cache_resources struct? IMHO, "struct netfs_cache_resources" is more like an interface for netfs, while here __cachefiles_prepare_write() and __cachefiles_write() are called inside Cachefiles module. -- Thanks, Jeffle