Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 9 Apr 2022 17:47:14 +0200
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     Thorsten Leemhuis <regressions@leemhuis.info>,
        Piotr Chmura <chmooreck@gmail.com>
Cc:     Robert Schlabbach <robert_s@gmx.net>,
        LMML <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Antti Palosaari <crope@iki.fi>
Subject: Re: [PATCH v3] si2157: unknown chip version Si2147-A30 ROM 0x50
Message-ID: <20220409174714.0c94f78d@coco.lan>
In-Reply-To: <20220409173138.2a9d8a6e@coco.lan>
References: <c4bcaff8-fbad-969e-ad47-e2c487ac02a1@gmail.com>
        <f2fc5822-56fb-26e8-00f3-71d2e359cf80@leemhuis.info>
        <20220409173138.2a9d8a6e@coco.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Em Sat, 9 Apr 2022 17:31:38 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:

> Em Sat, 9 Apr 2022 14:53:52 +0200
> Thorsten Leemhuis <regressions@leemhuis.info> escreveu:
>=20
> > Hi, this is your Linux kernel regression tracker. Top-posting for once,
> > to make this easily accessible to everyone.
> >=20
> > Mauro, what's the hold-up here? Below patch is fixing a regression
> > caused by one of your patches. Why haven't you applied this or provided
> > feedback to Piotr what needs to be improved? Or am I missing something
> > and progress was made? =20
>=20
> We're currently without a sub-maintainer for dvb, so it takes a longer
> time for patches like that to be noticed.
>=20
> In the specific case of this patch, the problem is that it doesn't apply.=
..
> The emailer mangled the patch, replacing spaces by U+0xa0 characters.
>=20
> Piotr,
>=20
> Please re-submit them with git send-email (or use some other client
> that won't damage whitespaces.

Nevermind. as the patch is short, I fixed it this time. Next time, please
check please use an emailer that is capable of properly encoding whitespaces
and tabs.

Regards,
Mauro

>=20
> Regards,
> Mauro
>=20
> >=20
> > This really is overdue, the first version of this patch was already
> > posted two and a half weeks ago. Reminder, the newly added document on
> > handling regressions (
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree=
/Documentation/process/handling-regressions.rst#n132
> > ) for this case states this as rule of thumb: "Aim to fix regressions
> > within one week ".
> >=20
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> >=20
> > P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > reports on my table. I can only look briefly into most of them and lack
> > knowledge about most of the areas they concern. I thus unfortunately
> > will sometimes get things wrong or miss something important. I hope
> > that's not the case here; if you think it is, don't hesitate to tell me
> > in a public reply, it's in everyone's interest to set the public record
> > straight.
> >=20
> >=20
> > #regzbot poke
> >=20
> >=20
> > On 31.03.22 17:55, Piotr Chmura wrote: =20
> > > Fix firmware file names assignment in si2157 tuner, allow for running
> > > devices without firmware files needed.
> > >=20
> > >=20
> > > It's regression in kernel 5.17.0, worked fine in 5.16 series.
> > >=20
> > > device: 07ca:1871 AVerMedia Technologies, Inc. TD310 DVB-T/T2/C dongle
> > > modprobe gives error: unknown chip version Si2147-A30 ROM 0x50
> > > Device initialization is interrupted.
> > >=20
> > > caused by:
> > > 1. table si2157_tuners has swapped fields rom_id and required vs stru=
ct
> > > si2157_tuner_info.
> > > 2. both firmware file names can be null for devices with required =3D=
=3D
> > > false - device uses build-in firmware in this case
> > >=20
> > > Fix:
> > > 1. Rearrange fields in table si2157_tuners
> > > 2. Allow both firmware file names be NULL for devices defined with
> > > required =3D=3D false
> > >=20
> > >=20
> > > Fixes: 1c35ba3bf972 ("media: si2157: use a different namespace for
> > > firmware")
> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D215726
> > > Link:
> > > https://lore.kernel.org/lkml/5f660108-8812-383c-83e4-29ee0558d623@lee=
mhuis.info/
> > >=20
> > > Cc: stable@vger.kernel.org # 5.17.x
> > > Signed-off-by: Piotr Chmura <chmooreck@gmail.com>
> > > Tested-by: Robert Schlabbach <robert_s@gmx.net>
> > >=20
> > > ---
> > >=20
> > > --- a/drivers/media/tuners/si2157.c=C2=A0=C2=A0=C2=A0 2022-03-20 21:1=
4:17.000000000 +0100
> > > +++ b/drivers/media/tuners/si2157.c=C2=A0=C2=A0=C2=A0 2022-03-22 23:4=
8:05.604408331 +0100
> > > @@ -77,16 +77,16 @@ err_mutex_unlock:
> > > =C2=A0}
> > >=20
> > > =C2=A0static const struct si2157_tuner_info si2157_tuners[] =3D {
> > > -=C2=A0=C2=A0=C2=A0 { SI2141, false, 0x60, SI2141_60_FIRMWARE, SI2141=
_A10_FIRMWARE },
> > > -=C2=A0=C2=A0=C2=A0 { SI2141, false, 0x61, SI2141_61_FIRMWARE, SI2141=
_A10_FIRMWARE },
> > > -=C2=A0=C2=A0=C2=A0 { SI2146, false, 0x11, SI2146_11_FIRMWARE, NULL },
> > > -=C2=A0=C2=A0=C2=A0 { SI2147, false, 0x50, SI2147_50_FIRMWARE, NULL },
> > > -=C2=A0=C2=A0=C2=A0 { SI2148, true,=C2=A0 0x32, SI2148_32_FIRMWARE, S=
I2158_A20_FIRMWARE },
> > > -=C2=A0=C2=A0=C2=A0 { SI2148, true,=C2=A0 0x33, SI2148_33_FIRMWARE, S=
I2158_A20_FIRMWARE },
> > > -=C2=A0=C2=A0=C2=A0 { SI2157, false, 0x50, SI2157_50_FIRMWARE, SI2157=
_A30_FIRMWARE },
> > > -=C2=A0=C2=A0=C2=A0 { SI2158, false, 0x50, SI2158_50_FIRMWARE, SI2158=
_A20_FIRMWARE },
> > > -=C2=A0=C2=A0=C2=A0 { SI2158, false, 0x51, SI2158_51_FIRMWARE, SI2158=
_A20_FIRMWARE },
> > > -=C2=A0=C2=A0=C2=A0 { SI2177, false, 0x50, SI2177_50_FIRMWARE, SI2157=
_A30_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2141, 0x60, false, SI2141_60_FIRMWARE, SI2141=
_A10_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2141, 0x61, false, SI2141_61_FIRMWARE, SI2141=
_A10_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2146, 0x11, false, SI2146_11_FIRMWARE, NULL },
> > > +=C2=A0=C2=A0=C2=A0 { SI2147, 0x50, false, SI2147_50_FIRMWARE, NULL },
> > > +=C2=A0=C2=A0=C2=A0 { SI2148, 0x32, true,=C2=A0 SI2148_32_FIRMWARE, S=
I2158_A20_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2148, 0x33, true,=C2=A0 SI2148_33_FIRMWARE, S=
I2158_A20_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2157, 0x50, false, SI2157_50_FIRMWARE, SI2157=
_A30_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2158, 0x50, false, SI2158_50_FIRMWARE, SI2158=
_A20_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2158, 0x51, false, SI2158_51_FIRMWARE, SI2158=
_A20_FIRMWARE },
> > > +=C2=A0=C2=A0=C2=A0 { SI2177, 0x50, false, SI2177_50_FIRMWARE, SI2157=
_A30_FIRMWARE },
> > > =C2=A0};
> > >=20
> > > =C2=A0static int si2157_load_firmware(struct dvb_frontend *fe,
> > > @@ -178,7 +178,7 @@ static int si2157_find_and_load_firmware
> > > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 }
> > > =C2=A0=C2=A0=C2=A0=C2=A0 }
> > >=20
> > > -=C2=A0=C2=A0=C2=A0 if (!fw_name && !fw_alt_name) {
> > > +=C2=A0=C2=A0=C2=A0 if (required && !fw_name && !fw_alt_name) {
> > > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 dev_err(&client->dev,
> > > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 "unkno=
wn chip version Si21%d-%c%c%c ROM 0x%02x\n",
> > > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 part_i=
d, cmd.args[1], cmd.args[3], cmd.args[4], rom_id);
> > >    =20
> >  =20
>=20
>=20
>=20
> Thanks,
> Mauro


Thanks,
Mauro