Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220411080120.26008-2-Ping-lei.Lin@mediatek.com>
References: <20220411080120.26008-1-Ping-lei.Lin@mediatek.com> <20220411080120.26008-2-Ping-lei.Lin@mediatek.com>
Subject: Re: [PATCH v2 1/2] media: usb: uvc: Add H265 pixel format
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
        Arnd Bergmann <arnd@arndb.de>,
        Ricardo Ribalda <ribalda@chromium.org>,
        Ming Qian <ming.qian@nxp.com>,
        Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, ping-lei.lin@mediatek.com,
        lecopzer.chen@mediatek.com, max.yan@mediatek.com,
        sherlock.chang@mediatek.com, tm.wu@mediatek.com,
        James_Lin <Ping-lei.Lin@mediatek.com>
To:     James_Lin <Ping-lei.Lin@mediatek.com>, linux-kernel@vger.kernel.org
Date:   Mon, 11 Apr 2022 09:11:25 +0100
Message-ID: <164966468564.22830.10326597921182135832@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting James_Lin (2022-04-11 09:01:19)
> Add H265 pixel format.
> So driver can recognize external camera devices=20
> whom use h265 to describe High Efficiency Video Coding method.
>=20
> Signed-off-by: James_Lin <Ping-lei.Lin@mediatek.com>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 5 +++++
>  drivers/media/usb/uvc/uvcvideo.h   | 3 +++
>  2 files changed, 8 insertions(+)
>=20
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/u=
vc_driver.c
> index dda0f0aa78b8..ebb807c33e57 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -154,6 +154,11 @@ static struct uvc_format_desc uvc_fmts[] =3D {
>                 .guid           =3D UVC_GUID_FORMAT_H264,
>                 .fcc            =3D V4L2_PIX_FMT_H264,
>         },
> +       {
> +               .name           =3D "H.265",
> +               .guid           =3D UVC_GUID_FORMAT_H265,
> +               .fcc            =3D V4L2_PIX_FMT_H265,

This is not yet defined I believe, so this patch needs to be 2/2 in this
series - with your following patch first so that they can both compile
independently.

> +       },
>         {
>                 .name           =3D "Greyscale 8 L/R (Y8I)",
>                 .guid           =3D UVC_GUID_FORMAT_Y8I,
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvc=
video.h
> index 143230b3275b..41f4d8c33f2a 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -139,6 +139,9 @@
>  #define UVC_GUID_FORMAT_H264 \
>         { 'H',  '2',  '6',  '4', 0x00, 0x00, 0x10, 0x00, \
>          0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_H265 \
> +       { 'H',  '2',  '6',  '5', 0x00, 0x00, 0x10, 0x00, \
> +        0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
>  #define UVC_GUID_FORMAT_Y8I \
>         { 'Y',  '8',  'I',  ' ', 0x00, 0x00, 0x10, 0x00, \
>          0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> --=20
> 2.18.0
>