Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp11203pxb; Mon, 11 Apr 2022 17:24:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEy12r/iYooT7QyiUCR7ZeDI0GIyJ9upxoPsP4Qmj4ubqBhVQixfHrj7l9qTFY8Lb2rVJQ X-Received: by 2002:a17:902:8506:b0:154:8692:a7ac with SMTP id bj6-20020a170902850600b001548692a7acmr35236978plb.10.1649723045605; Mon, 11 Apr 2022 17:24:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649723045; cv=none; d=google.com; s=arc-20160816; b=lnnYyPuxTNIHLYah1Hl3mBA6xCxgjODl/IL0yeZ2Jl5TaqdyEK2v8+cUSgXQqhK12N WFt+1352bFQE/RXXhba9C7CJmBCHNvvA8ME+XIVxKQr3DjqQ8HX1nqaWhgMAqTvbMZp8 ytB+Ta3mw+UHzbKKwTzE0sNUzs/+bF87nWXjlKE6UyAy+dOG5Q6g6THLIl7zxED3NErc 629hi4OOvKcdX89gM1ejHJMyG6MiHEB4BfmPg9Yz01Ggp/Q0CbIWlKmPKKUIRyaKTWge zgVbtkX8CGr88nbSwGZnNhk902J4TTtIr3LeiSVpuTY+jzjb5tCHOto4ucYYfG/JDmvI 7qbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m5SMTicrNbfMR4aQtn34unS3/q/ePikyHnBg83o5CYc=; b=xTFupBtPgX9EfuIpLAP9qwtXUT7M07vyJV28WSBcSqEw7KqHtXKeUqu60RLu+Pv4mv 8QGveK+czauGvd55KAmAA/Y9OYYcacRVYpUA8F5edf8u7pHmY2cgHf9Qx5LzSmtXAb8c UCvJ/C60vW/t+ScYtYSp6RIfP5IUy+t8fdeboiy9NDYW9AhPxkqQHeVCbRMGV5dRdkw1 NYx73m58jiKk8oEdP+MXJgUmxNCSlAla+sTG6qwbSNDIH9t1xr7JmZPpJ1yBOrqokRIg M3e9WJtaOaFmxsusxszyHrDj8qlVPfK3mhJmHAUWMf/vEjuBqnl6jzgfZqjl4T+YtgqC PaKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fxmI5vEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rm5-20020a17090b3ec500b001bd14e03091si10320474pjb.105.2022.04.11.17.23.50; Mon, 11 Apr 2022 17:24:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fxmI5vEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346537AbiDKNgz (ORCPT + 99 others); Mon, 11 Apr 2022 09:36:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346531AbiDKNgw (ORCPT ); Mon, 11 Apr 2022 09:36:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD162A180; Mon, 11 Apr 2022 06:34:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 70EF960B9C; Mon, 11 Apr 2022 13:34:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B146C385AA; Mon, 11 Apr 2022 13:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649684076; bh=T15d2lZIS7swr10X+ACZq35v4lVQuqNfhmMmHgFlVEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fxmI5vEYYGnZz+aTsqRn57VN3tuLDQmmAyMmtcX7SdQiH8i6Q2n+Y1c5j9tpfIhQB 3zGtY7Gm4oHSlKlsMhFZ93w5VIuXOQG74WifgOtVxSJF11/lmHbiYPQaotDACMtKMP +i05rnnYY0+oNsCFhFS+Zt8+mMEQMBoKCiZoTfoD1GO/gK/DazWCr8FP6FAAYWuQOY K2GtGBpIT0er7smCTtzg9FjNLDv4GIJQ783svxSVro7e4NskBw/a1UbfoxYcKb6ILa yHuTrMjtMglM68iK1JeQlQUYneRRhrgPLB5/bsEyIj52vENWWisyO3BTxb4ifCdaFS vlSRyr/kIG2TQ== Date: Mon, 11 Apr 2022 19:04:32 +0530 From: Vinod Koul To: Xiaomeng Tong Cc: ludovic.desroches@microchip.com, tudor.ambarus@microchip.com, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] dma: at_xdmac: fix a missing check on list iterator Message-ID: References: <20220327061154.4867-1-xiam0nd.tong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220327061154.4867-1-xiam0nd.tong@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27-03-22, 14:11, Xiaomeng Tong wrote: > The bug is here: > __func__, desc, &desc->tx_dma_desc.phys, ret, cookie, residue); > > The list iterator 'desc' will point to a bogus position containing > HEAD if the list is empty or no element is found. To avoid dev_dbg() > prints a invalid address, use a new variable 'iter' as the list > iterator, while use the origin variable 'desc' as a dedicated > pointer to point to the found element. Applied, thanks -- ~Vinod