Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eac41cf0-6057-2f52-26fd-50a0fbecd7a8@nvidia.com>
Date:   Mon, 11 Apr 2022 11:50:14 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Patch v6 1/4] memory: tegra: Add memory controller channels
 support
Content-Language: en-US
To:     Dmitry Osipenko <digetx@gmail.com>, krzysztof.kozlowski@linaro.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc:     vdumpa@nvidia.com, Snikam@nvidia.com
References: <20220406052459.10438-1-amhetre@nvidia.com>
 <20220406052459.10438-2-amhetre@nvidia.com>
 <bf23e357-1e74-6bbe-7f37-11147654e5fc@gmail.com>
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <bf23e357-1e74-6bbe-7f37-11147654e5fc@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHJyMlROVW9qSTdWOGRBUE9iTHFRRHBGVzI1RzJuR3o2RjFwNExtVUVKUERq?=
 =?utf-8?B?a3lUNzJiQkhCUjdEYU1RekRnanhnVDdhay92R3ZvRTRidjZSOVBqaUM1YXJU?=
 =?utf-8?B?WWRlRmsydjh1N1NGbks4a2Q5RUdBWGsvTHo4LzlrV1FQWUFDZWRQSy9YREJt?=
 =?utf-8?B?dUF0dzFTUHhXRHdzbExCNlBaOHdCekZCbmp6dnNDa244YUxnNkRqaE1zeHlh?=
 =?utf-8?B?ZWhDbStFQzFEaWdhVnE2ZkxJb0RSWDBoYVNDdXpjQWp3dHRPcEpyeWtRcjh5?=
 =?utf-8?B?eVpnckZhbUN1WXdoK3B3M24vSzRpeDFKWjRGb2R1aWZWQmVqa2NCVjFxcHZ4?=
 =?utf-8?B?RGduU3p4WWIwaEZka01mUWpvVG5tb1JSUytpaVA3UlhpZ2k0UmR0RHpBNVhj?=
 =?utf-8?B?YWc4NkpNdUVEcjk3WnJFVzJlUHFZSWx2a1hFUjdSWGs2QkJuRmdkb1RkRTNX?=
 =?utf-8?B?TDhxRGk0OTYrdmFpUE5PcFFwRmtlSWt6MFVraHJ4SGFxaW4ycHNVODZ2Vm10?=
 =?utf-8?B?bW1VQy81SFZMa2E2Zm96NGcyUG9ocWZldXl5MWtNL1oxREhnWlJ6NU9LUjRo?=
 =?utf-8?B?VGF6ZENtTE8ra2RCbWlDdGhaWWJORFp2aTFVTDZKd1RwU0hYL2JPSTlVa0Ry?=
 =?utf-8?B?LzJKN3BUYm1WYWlwTThranA1SlQ4MmxhRmRDV0dkVXczc1EvUTlRUVhSRDRZ?=
 =?utf-8?B?RU1lRStTalhPNmgrWm41NFdOV0RZN09HZWNnRjlTQUNhbkxKQ2x1RXI1aWdT?=
 =?utf-8?B?WGdYSWgyakxYaDhiSDhVVHRkUXNEQXp5Sk9XVnBGeDdEbER2ZnZVR1VqYjkv?=
 =?utf-8?B?YWZJWnZZQnVCYnpBL1hpbTk2WG15bEE2bS9vQ2ZNZ2tuUUFaSk9VdHRiVXBt?=
 =?utf-8?B?UGFtYWo3bll6ZUhTaGl5aTZMWWZXQ01jaVlpQ3BlU3duYnN1Qkl4S1ZNWHZk?=
 =?utf-8?B?ak5ubDVJckpOL2V4TGUyN01vbm5JcEpNRnNKNzZHNGRVaXI2bTYvREJSSFhi?=
 =?utf-8?B?dzhrOEJVRTRaRlZlTEU3dE42ZTdGc05BS0E0TkJiRFZPNFRPalI2clU4Q0lN?=
 =?utf-8?B?MGdmT04rYkN6OHErS2xXeVBvZFZWeHR2MGJ0VjZoOGlsU0FlSUxqaW9Na1ly?=
 =?utf-8?B?bjlnUmg2QVdOLzMyTVF1dzhZZXRDL2NJb1JaNlNodTR4TXlnRGF3am0vZE5h?=
 =?utf-8?B?TStsVFU4dnczK2FYTm9zcnkrLy9hWVd3M2hVeE5ZK2RUb0RPTTN1NUVlVmJq?=
 =?utf-8?B?QXgyNE8vVXFaL2lmU2hYZlZwZUlvK3dUYnVLNlk1aUhtbmdhNTlleGg4ZkE0?=
 =?utf-8?B?TUkyTys3QUFyTjNjQ2FDVEZMVHZaWE1rSnVVemlKejF6U1NxRFNWOEM1K1N4?=
 =?utf-8?B?QnhBSWczYmpZQnprZ3lXMDRDeDF2aVgwVVZIbnV6YkNiRmNQaCtkaVVrYzZU?=
 =?utf-8?B?cklJSyt2TVhKZ3Y2OWtzSmRuYzA2YUxGWng1eDd4ZXBqNUxmclppcFBmU3FN?=
 =?utf-8?B?cUhpeGMxQU9HODhuVGNKZTJ4VUk1U3RIeEtyOG0wdm51eUE0eHNkNW80d0h6?=
 =?utf-8?B?QWJaZmJCMEgvTVdQR2hQNGhPNUsxeUZzUWNWOWZqNVZWUnFrN3NzZzhJUUhO?=
 =?utf-8?B?U1NpOXZ0YzNhVUFhLzA5VWNZb2dncU1heHJTT3hVZ1lTVmpDQWVQWTkxYWNI?=
 =?utf-8?B?OVRyaS9lb2FQaC9LL3VJYnNVQmxkRlBLQ043aTEwNUU1R2hObkxIRzFaSEtW?=
 =?utf-8?B?TkhiN2QvMUdxVzlkTGNWMkluYmdUeWljQWZnTURxK05rYXhQZmtNeFhOMnJH?=
 =?utf-8?B?bG9ucWZDblJBa0Q4VmQ5K0pBT1JnYXdTOVVCMm5TMlFMaGdtUUo4Z3c2ZjBU?=
 =?utf-8?B?VnZiNUhLUEpYdnBSMFYxQjQvbThraDNIaGJoUWJSbzhxZnpqV1NuMzRXMWYr?=
 =?utf-8?B?MDRGUUJrYk9ILzdwUUVqOVJZU0lDVXBoTkhBNU11YzBOWXp4YS90MStIRDRZ?=
 =?utf-8?B?RjQ5dFR4WGxVdUxqVldvL2Faa1lFNHN6SlVEc2M2aDNQY0c1cGJBTllqL2ll?=
 =?utf-8?B?UTJNT3JMcnJ3UnFyV3greU9jMm9GMU91eXhtSmtxTXZtRTdNeFdtcEU4djZx?=
 =?utf-8?B?M2xYZG12SWQ1dFU2am9XemJ5Y1VFeDlBOWxqc1NINGRIV0dhQzhVdFdPcDFi?=
 =?utf-8?B?aCtaWjFzdnQ1anVLcmlhYVJ0K2V6QTNGamFIN0VnWFRiY0dDTm9SWDNSYUsw?=
 =?utf-8?B?SHh3a0UxTXlOdmlSbVRudUUyaWplcHpIS0VuMTJFc2R3WVdsUDdCT2FkZzY0?=
 =?utf-8?B?eEtjQzI0MUVnbnlXdFdBdHNxYUZlWHg1aFoxbVhsajIxWkkrb3VTdz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fccd836-5757-4b08-382c-08da1b835f23
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4349.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 06:20:28.0606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vy6T6LpTi1OX3wWrfW4VHJNaFTZ1UZrcBtSLsyNEoRvlQ3KLZr/alxKFhUe6UtzbmgVmYrSZYNnwe24NWqcC6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2872
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/10/2022 8:34 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> 06.04.2022 08:24, Ashish Mhetre пишет:
>> diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
>> index 1066b1194a5a..c3c121fbfbb7 100644
>> --- a/include/soc/tegra/mc.h
>> +++ b/include/soc/tegra/mc.h
>> @@ -13,6 +13,9 @@
>>   #include <linux/irq.h>
>>   #include <linux/reset-controller.h>
>>   #include <linux/types.h>
>> +#include <linux/platform_device.h>
>> +
>> +#define MC_MAX_CHANNELS 16
>>
>>   struct clk;
>>   struct device;
>> @@ -181,6 +184,7 @@ struct tegra_mc_ops {
>>        int (*resume)(struct tegra_mc *mc);
>>        irqreturn_t (*handle_irq)(int irq, void *data);
>>        int (*probe_device)(struct tegra_mc *mc, struct device *dev);
>> +     int (*map_regs)(struct tegra_mc *mc, struct platform_device *pdev);
>>   };
>>
>>   struct tegra_mc_soc {
>> @@ -194,6 +198,7 @@ struct tegra_mc_soc {
>>        unsigned int atom_size;
>>
>>        u8 client_id_mask;
>> +     u8 num_channels;
>>
>>        const struct tegra_smmu_soc *smmu;
>>
>> @@ -212,6 +217,8 @@ struct tegra_mc {
>>        struct tegra_smmu *smmu;
>>        struct gart_device *gart;
>>        void __iomem *regs;
>> +     void __iomem *bcast_ch_regs;
>> +     void __iomem *ch_regs[MC_MAX_CHANNELS];
> 
> Why not to allocate ch_regs at runtime?

Yes, we can do that. I'll make necessary changes in v7.