Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 9 Apr 2022 09:46:32 -0400
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Maxim Devaev <mdevaev@gmail.com>
Cc:     linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Cai Huoqing <caihuoqing@baidu.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: break IO operations via
 configfs
Message-ID: <YlGOOJ9SwkD7WVmX@rowland.harvard.edu>
References: <20220406092445.215288-1-mdevaev@gmail.com>
 <Yk2wvhSTMKTLFK6c@rowland.harvard.edu>
 <20220406195234.4f63cb4a@reki>
 <Yk3TLPKyaQDsnuD4@rowland.harvard.edu>
 <20220406213634.104cae45@reki>
 <Yk8L6b9wEWTjWOg4@rowland.harvard.edu>
 <20220407204553.35cead72@reki>
 <YlBN4Zcn9NYw0PLA@rowland.harvard.edu>
 <20220409115756.4f9b015d@reki>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220409115756.4f9b015d@reki>
Precedence: bulk

On Sat, Apr 09, 2022 at 11:57:56AM +0300, Maxim Devaev wrote:
> В Fri, 8 Apr 2022 10:59:45 -0400
> Alan Stern <stern@rowland.harvard.edu> wrote:
> > > At least there is one situation where the behavior of f_mass_storage differs
> > > from the behavior of a real drive. What happens when you click on the physical
> > > "eject" button?  
> > 
> > If the host has prevented ejection, nothing happens.  Otherwise the disc 
> > gets ejected.
> > 
> > > Yes, the OS can block this, but the problem is that we don't have
> > > an "eject" here.  
> > 
> > What do you mean?  Writing an empty string to the sysfs "file" attribute 
> > is the virtual analog of pressing the eject button.
> 
> But I can't eject the disc event it's not mounted on Linux host. It seems to me
> it differs from the real drive behavior.

It sounds like either there's a bug or else you're not doing the right 
thing.  Tell me exactly what you do when this fails.

> > ...
> 
> I have reflected on the rest of your arguments and changed my mind.
> I think that "forced_eject" for a specific lun without interrupting operations would
> really be the best solution. I wrote a simple patch and tested it, everything seems
> to work. What do you think about something like this?
> 
> 
> static ssize_t fsg_lun_opts_forced_eject_store(struct config_item *item,
>                                                const char *page, size_t len)
> {
>         struct fsg_lun_opts *opts = to_fsg_lun_opts(item);
>         struct fsg_opts *fsg_opts = to_fsg_opts(opts->group.cg_item.ci_parent);
>         int ret;
> 
>         opts->lun->prevent_medium_removal = 0;
>         ret = fsg_store_file(opts->lun, &fsg_opts->common->filesem, "", 0);
>         return ret < 0 ? ret : len;
> }
> 
> CONFIGFS_ATTR_WO(fsg_lun_opts_, forced_eject);

The basic idea is right.  But this should not be a CONFIGFS option; it 
should be an ordinary LUN attribute.  For an example, see the definition of 
file_store() in f_mass_storage.c; your routine should look very similar.

> If you find this acceptable, I will test this patch on my users to make sure
> that its behavior meets our expectations.

Okay.

Alan Stern