Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by
 dtbscheck
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <535e3eab-a28e-46f3-2a7e-f1ffd1913470@linaro.org>
Date:   Sat, 9 Apr 2022 15:32:31 +0200
Cc:     Rob Herring <robh+dt@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <7B66AC66-EF73-4F75-A775-589A4F98BEFC@goldelico.com>
References: <cover.1649443080.git.hns@goldelico.com>
 <298162bfa2e7225ccc753865e1ffa39ce2722b2a.1649443080.git.hns@goldelico.com>
 <bd19b6eb-d53a-b665-749d-46c275c85ccc@linaro.org>
 <822182F3-5429-4731-9FA1-8F18C5D95DEC@goldelico.com>
 <535e3eab-a28e-46f3-2a7e-f1ffd1913470@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> Am 09.04.2022 um 15:15 schrieb Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org>:
>=20
> On 09/04/2022 15:05, H. Nikolaus Schaller wrote:
>>>=20
>>> This looks wrong, the block usually should have a specific =
compatible.
>>> Please mention why it does not.
>>=20
>> Well, I did not even have that idea that it could need an =
explanation.
>>=20
>> There is no "ingenic,jz4780-otg" and none is needed here to make it =
work.
>=20
> Make it work in what terms? We talk about hardware description, right?

Yes.

>=20
>>=20
>> Therefore the generic "snps,dwc2" is sufficient.
>=20
> No, you are mixing now driver behavior (is sufficient) with hardware
> description.

No. "snps,dwc2" is a hardware description for a licensed block.
Not a driver behavior.

> Most of licensed blocks require the specific compatible to
> differentiate it.

If there is a need to differentiate.=