Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Yang Guang <yang.guang5@zte.com.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Colin Ian King <colin.king@intel.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] media: saa7134: simplify if-if to if-else
Date:   Mon, 11 Apr 2022 18:56:49 +0800
Message-Id: <20220411105650.723082-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ChUGFLUW8JAdF3YWgJ14cxT+49DbXiKJUfDrHS3c+j8JUPFWIXHnqTt/NvVj?=
 =?us-ascii?Q?aHFTFVQ95Gzh8hlZOYn7CoM0+KqZ6c5q7JnmBXtseh/6Y7vtRko5WS2bXR8N?=
 =?us-ascii?Q?aOPmYN+eGdH0wyk0vkp6dvdw0Wr7fb9uzXkG7aewlw4wJaYETCXBe3hLqFzL?=
 =?us-ascii?Q?O8AsuTL6jyFkvQZpkUlGE8D5VGanKPwARYzlQu99gsf6NqNuk8DXnSZfysBZ?=
 =?us-ascii?Q?gWJs7S++FyEfPIzaT775Tdktc4ghCDsTVlvpiGirqglDVbMc3hJkZkvu0QXT?=
 =?us-ascii?Q?8TxEqlGpK9ASbUlj55l7MezqpN6cjBiCtCotAoBcBrEmsdyLiRVuFbmaxDa8?=
 =?us-ascii?Q?Mm5Z1tH0Y6N8MZgomXvplCOpU80x1vRbDjuu8j4eqLc8PemBg9eh9ci1oImq?=
 =?us-ascii?Q?qAKACnzz27StmYjugon1EF3uIMSn69lLkY5aZg3ZqAKemaNYip2Uv12yr5aW?=
 =?us-ascii?Q?RdfGY1w2X7H8zS79xPLf9DF1Bvnf8Lm6BaT1el0R+aGHpacz3nye8Vqptoiq?=
 =?us-ascii?Q?TN2MSoqpXz6uvgW+KGnP/u8walVA8xuBsT7qORqoVKLQvnI9W22jW5ihrbCL?=
 =?us-ascii?Q?++4GlDW4H0QWrI+HTvaT9ugVKMGaFi/j4ayFAJDbJENkaDN/gT3uTURCKPPR?=
 =?us-ascii?Q?+alOn1fdDe7vTHSKcBhkydOBCdeA8+vRWcnZq9kGB9tWqhsNBm9hyLXBfd5x?=
 =?us-ascii?Q?EsNYkr1lAnohy41TRKj7NP/vU6tUek2pVVhFPHixsqPQcincSCqkt8/XL/g8?=
 =?us-ascii?Q?GMEdgw4e892nCUzc3JtCeBMPM1QCje7W5fuF78jiaEfexcGYkziZlBX6VfqM?=
 =?us-ascii?Q?pmFWeeiaZ3Guu097n6skJ4pY1Y8+aMGmMHcdQr5AOhy2bv+E/EJkrN1BMWyA?=
 =?us-ascii?Q?7S2t8wAqN7nrVA5cMk9uPRRnN1U3pDzd31Joq/Cvq6nJsz9P+0Oo7mn1hEQg?=
 =?us-ascii?Q?ExSanp7ZY2LETPhSk7fSGG4dOhJ15C8ZWuYxV+PY9WLuFXMv9FBWr8Ogykg+?=
 =?us-ascii?Q?CEsLrCU9m0PxeADyxd7qRPiOCBZzv04APaQhuC/TBcPWm7LJKl0h0LBG3koL?=
 =?us-ascii?Q?y1dcPLAI8dX2ddzHEnJhJ8F+RCodFf2G96pcd86rnn9AtPhkrM0DpJzmnUPw?=
 =?us-ascii?Q?6dNekPkQ55K102CEdkyeKng97zpGmRPnIm8HNi+ZrFfLGne2KjCA3rtOgJ6m?=
 =?us-ascii?Q?mpQdHhDo/HJUZIOgoa26yzMXjoKjgT7G0iPuAf4k5QH0BnK6nycNOSW8+nPf?=
 =?us-ascii?Q?IoPmWZpKxp3mV559EofIjhkcpm9KRnpR/PfcZQ4N79+DO1j0AMlBw4HawGoU?=
 =?us-ascii?Q?4SqFWlXAk0ACSEX4sEojM8ya2nW1OOzxp//Ab2Mzj3UC6bmArp06iLrJbGoP?=
 =?us-ascii?Q?uaR/+MiwxPYWEnCrVpTix93hq10/lfSiIqTMLbCQjvKw/8W8GAR9kRewBeBk?=
 =?us-ascii?Q?d15NgttDUByY1yU0wJ8OXrPgNugmb9IEWJIPFNxGoDxB9qdgPBAF2dQHquA6?=
 =?us-ascii?Q?eBbeQ2TqE1ZUESshyjiJxA/K0SV+IQZxbxzl6XSmlXz+Wzd0itpW8ekI/pvM?=
 =?us-ascii?Q?UJlPZs68TU/gNOetAF01b0+epr6YgTSdV3v2X4tVad8FMTY26QyKVD7cvnpm?=
 =?us-ascii?Q?dzN6vcLAgGxMHkTnGy0RUuAy+0XaDIjy5hkFmWh+9dWtjvNZopRNGowo2vPv?=
 =?us-ascii?Q?S40OqRL08c7LGChpefQdtf/qzj5asCQZswdB80nmkdac40pHE5VDcoEZw/Vo?=
 =?us-ascii?Q?0sxYnWnxVA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72763a96-cc37-4d0d-7415-08da1baa0660
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 10:57:09.9064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mOcxZQS6CUPTOWLk5YSl5YWs8PhZTq74j+9Uj6qOC4Sxlm2Cwuok5+jMADzd9CK7iu1zTJvwyLzLzi1b7PvW5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2289
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

use if and else instead of if(A) and if (!A).

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/media/pci/saa7134/saa7134-video.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c
index 48543ad3d595..61e678c1c2f6 100644
--- a/drivers/media/pci/saa7134/saa7134-video.c
+++ b/drivers/media/pci/saa7134/saa7134-video.c
@@ -1833,8 +1833,7 @@ static int saa7134_overlay(struct file *file, void *priv, unsigned int on)
 		spin_lock_irqsave(&dev->slock, flags);
 		start_preview(dev);
 		spin_unlock_irqrestore(&dev->slock, flags);
-	}
-	if (!on) {
+	} else {
 		if (priv != dev->overlay_owner)
 			return -EINVAL;
 		spin_lock_irqsave(&dev->slock, flags);
-- 
2.35.1