Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad3720df-73d4-5463-a538-d921cdf9f0b3@svenschwermer.de>
Date:   Fri, 8 Apr 2022 20:54:34 +0200
Mime-Version: 1.0
Subject: Re: [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem
Content-Language: en-US
To:     =?UTF-8?Q?Bj=c3=b8rn_Mork?= <bjorn@mork.no>,
        Lars Melin <larsm17@gmail.com>
Cc:     linux-usb@vger.kernel.org,
        Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
        linux-kernel@vger.kernel.org, oliver@neukum.org
References: <20220407074745.74195-1-sven@svenschwermer.de>
 <20220407074745.74195-2-sven@svenschwermer.de>
 <3b8a8497-df41-8bf4-6816-f4419cb7f950@gmail.com>
 <87ee27y9ym.fsf@miraculix.mork.no>
From:   Sven Schwermer <sven@svenschwermer.de>
In-Reply-To: <87ee27y9ym.fsf@miraculix.mork.no>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Lars,

On 4/8/22 15:35, Bjørn Mork wrote:
> Lars Melin <larsm17@gmail.com> writes:
> 
>> Why do you add this modem to the whitelist?
> 
> I believe the clue is the
> 
>> +	.driver_info = (unsigned long)&wwan_info,
> 
> to set FLAG_WWAN instead of the default FLAG_ETHER | FLAG_POINTTOPOINT

Bjørn is right that this is the reason. The Fibocom MA510 and L610 are 
cellular modems, so they require to be labelled as WWAN devices. As such 
they require to be set up (using AT commands or similar) before the 
connection can be used. Furthermore, WWAN devices get a different 
routing metric assigned by the network manager than regular Ethernet 
devices.

>> The net interface has the correct cdc_ether attributes so the
>> cdc_ether driver should bind automagically without any need for the
>> modem to be in the whitelist.
> 
> Yes, this sort of works against the class driver philosophy.  But we've
> already started down that road, so...
> 
> 
> 
> Bjørn