Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4d0cbb79-4955-a3ed-4aa2-7f6cdaa00481@gmail.com>
Date:   Sat, 9 Apr 2022 16:27:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Bug][5.18-rc0] Between commits ed4643521e6a and 34af78c4e616,
 appears warning "WARNING: CPU: 31 PID: 51848 at
 drivers/dma-buf/dma-fence-array.c:191 dma_fence_array_create+0x101/0x120" and
 some games stopped working.
Content-Language: en-US
To:     Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Cc:     thomas.hellstrom@linux.intel.com,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        "Deucher, Alexander" <alexander.deucher@amd.com>, Ken.Xue@amd.com
References: <CABXGCsNVp=R5zC9B3PXWJ5nddtt3gkRzDsAsRKvhXq7exGjSAg@mail.gmail.com>
 <f3bc34e1-0eaf-84ef-486e-b7759e60b792@amd.com>
 <CABXGCsOD+tDdFcM37NP_1nS9eLym7qC=jUQy3iqYkc1m2iQgxw@mail.gmail.com>
 <0d5f66d8-9852-b6a9-0e27-9eb9e736d698@amd.com>
 <CABXGCsPi68Lyvg+6UjTK2aJm6PVBs83YJuP6x68mcrzAQgpuZg@mail.gmail.com>
 <eef04fc4-741d-606c-c2c6-f054e4e3fffd@amd.com>
 <CABXGCsNNwEjo_dvWJL7GLULBPy+RmwsC9ObpowR_M1nQ3fKt3g@mail.gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken@gmail.com>
In-Reply-To: <CABXGCsNNwEjo_dvWJL7GLULBPy+RmwsC9ObpowR_M1nQ3fKt3g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Am 08.04.22 um 19:25 schrieb Mikhail Gavrilov:
> On Fri, 8 Apr 2022 at 19:27, Christian König <christian.koenig@amd.com> wrote:
>> Please test the attached patch, it just re-introduce the lock without
>> doing much else.
>>
>> And does your branch contain the following patch:
>>
>> commit d18b8eadd83e3d8d63a45f9479478640dbcfca02
>> Author: Christian König <christian.koenig@amd.com>
>> Date:   Wed Feb 23 14:35:31 2022 +0100
>>
>>       drm/amdgpu: install ctx entities with cmpxchg
>>
>>       Since we removed the context lock we need to make sure that not two
>> threads
>>       are trying to install an entity at the same time.
>>
>>       Signed-off-by: Christian König <christian.koenig@amd.com>
>>       Fixes: 461fa7b0ac565e ("drm/amdgpu: remove ctx->lock")
>>       Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>>       Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> The all listed games are now working with an attached patch.
> Also flood messages "WARNING: CPU: 31 PID: 51848 at
> drivers/dma-buf/dma-fence-array.c:191
> dma_fence_array_create+0x101/0x120" has gone.

That's unfortunately not the end of the story.

This is fixing your problem, but reintroducing the original problem that 
we call the syncobj with a lock held which can crash badly as well.

Going to take a closer look on Monday. I hope you can test a few more 
patches to help narrow down what's actually going wrong here.

Thanks,
Christian.

>
> Thanks.
>
> Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
>