Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "nakamura.shun@fujitsu.com" <nakamura.shun@fujitsu.com>
To:     'Jiri Olsa' <olsajiri@gmail.com>
CC:     "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@redhat.com" <jolsa@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>
Subject: RE: [RFC PATCH v2 4/7] libperf: Introduce perf_{evsel,
 evlist}__open_opt with extensible struct opts
Thread-Topic: [RFC PATCH v2 4/7] libperf: Introduce perf_{evsel,
 evlist}__open_opt with extensible struct opts
Thread-Index: AQHYRD0ilfomz6jCoE+uLALkEGmIQ6zqdFEw
Date:   Mon, 11 Apr 2022 08:31:47 +0000
Message-ID: <OSBPR01MB4600CAA1C7EC36CFCCEEDE95F7EA9@OSBPR01MB4600.jpnprd01.prod.outlook.com>
References: <20220325043829.224045-1-nakamura.shun@fujitsu.com>
 <20220325043829.224045-5-nakamura.shun@fujitsu.com> <YkRgJI913TCCCY2S@krava>
In-Reply-To: <YkRgJI913TCCCY2S@krava>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?ZDAvM3hBYUVLdmgzMVhPTk0xMjNqNG1JaS9DaVErUnBaZThjTjA4Q1VJ?=
 =?iso-2022-jp?B?dXAyS2x2dnNKdmYzZ3lFQm1icHFYYkRjMGhxRGVSZ1MvSUQwYjBEdXpT?=
 =?iso-2022-jp?B?QVkxZkZuSTlxTElTdWw2c3pyUDNtRjU5alNRdStYRmsxQjJ4NUd4WmtO?=
 =?iso-2022-jp?B?UW9lNk92RytybzMwb3NKeGpQY1BDN2d6MkRJQUlMUkxSd2xrVUgyazk4?=
 =?iso-2022-jp?B?YS96dzBYamNIRjVZcWhHUUU2UU9RbHkxUHdpM3NXa0RWZ2NhcmdvejVH?=
 =?iso-2022-jp?B?RHBpV3IvbmRIZndoUEdQR09NanFKZERyeGRxUnZrYW9KdHlTaHZSY0tu?=
 =?iso-2022-jp?B?OGJXNUlzeU9ydzBWK0V4amVjc3NMS1RSa00vRGJxY0RSbjAzZk9yb0E1?=
 =?iso-2022-jp?B?Y0ZycXlBdk5tUEVVaUN6ZTVBZVBDOWJsVThpTFJNQ2ZRUTltNGprSEto?=
 =?iso-2022-jp?B?TWRnVGFsU3JieGpZTWg1Zmh5a0o1QUJ5bGlaWkFRK1VROFZCZnYrMmhx?=
 =?iso-2022-jp?B?Yi9QZGcxWVBiczNZcXR4KzVUaFBZQjh4d3dzWk9wWWFNcDQ5TjZZVE9q?=
 =?iso-2022-jp?B?MkhhSzBqUFlPVnB6Qmo5MEJNbG1EZ3V0QlBPUVlBelM2Z0t0bzllNXBV?=
 =?iso-2022-jp?B?RXQ0NFJ1QUlweFJMNStLS3VTNE1qVWc0eFV4YTFqd1N1blhJb3VEc0xW?=
 =?iso-2022-jp?B?RUdxTmpCNktZMWlsYmxzRnJJRTFmOU1vZ2tjZEo5ZmF4akZJWEdjSVQr?=
 =?iso-2022-jp?B?NGY1b3dGcndFUVRpYkR5c3ZwOG0zV0JXWGlzNmhDK3VoV1VDT2lpaTFF?=
 =?iso-2022-jp?B?ekc3ZFI4bHlBdEd1c2hZWFlLaTlTYTN2a2RVS3B5VUVmaWtzRVpkUk5n?=
 =?iso-2022-jp?B?dnd3UFZwZVVLTkhGTDN3V0FIb0ZaOVQwdUMxZnNYYWVTbkdESWZCM0NX?=
 =?iso-2022-jp?B?Q1FiMENUNzhMRWhta3lJbkVYUzAyTXBWcGdqUjR3Q2FFc092dEx3dExD?=
 =?iso-2022-jp?B?ZE1ZUGJLNWxlMjdjU1RsZDk1b2xnQ3piYW1pT1FoRmd3YUhFbW1vQjlB?=
 =?iso-2022-jp?B?SWc4dlN5S2tVaDJOOE12alcxSVUrRzhKVVJ4OW1Kb2xBbktkRngzTG5v?=
 =?iso-2022-jp?B?dkhWdHRHYzFsQTFwbDhMSndwQW12dTM5NWp1MmozcGgrUlpLMmxXUjNS?=
 =?iso-2022-jp?B?TGhNUGlaNHhJS3gwTFduTGduUlNhUm95Ukk4aVFUN3YrRGFiSU1lYm5z?=
 =?iso-2022-jp?B?eHN3NUc5dlI3WTI2UERydkpGdGd3UUtEWWtKaHBiSkRjRHZucUVXVzlT?=
 =?iso-2022-jp?B?Ums4RmVaQllXRVBEUnBkdWt5aE8yYmcxWjdxSlNDTlZIUXpTUzFCR2h3?=
 =?iso-2022-jp?B?ajBhWWM2dWdTMHVlWnYyR3ZwRUNoNGF1V2Qwam5YcngzV3Z3MFg3MHNy?=
 =?iso-2022-jp?B?YUE4M1BNaWNzSEFwS1NRWXpaL3RwL1AzdWhKRXZoVXdJMEVwYkx5M1JG?=
 =?iso-2022-jp?B?OVVIUzF5ZGlvS0FmdmJRWWQ4MlovOFl5NmlocHdlN01OMmdPdDJ0Undu?=
 =?iso-2022-jp?B?ck9ObStlK29JZjBPckhjNU5XcGdoWXpBeEN0Q0Q0c0ZNN0d5cy9rOXVr?=
 =?iso-2022-jp?B?Ujg1QWJ1MmF5MmxpYyticGdRcU1oSU1XRnRvNXhvQVpFSTlVZzV6Ukkv?=
 =?iso-2022-jp?B?MG5PalBoL3lvV2M0eVczNXJtbVA4bUpKZTlWREFpQ0JBQmQxQTFuYzdC?=
 =?iso-2022-jp?B?Q2dWYm1LbnB4TUJFTmEwbEFWVmlEN2xBMFFleE5DOTdpMEpaTzVGK2wz?=
 =?iso-2022-jp?B?MjZKRlNxTzhSdWZra3U4VmlHdjNTMkNLMG9hVGZlYjdDUEQybjUrMWo2?=
 =?iso-2022-jp?B?bXRzbEwzRnZ6YVV6T09ncG1XWmhocC8wbzMyRWhsU1N1b0lsdFMrSUl4?=
 =?iso-2022-jp?B?blhYK3hnQmt1cEswTkRWTWZ2eFV6L1grQWFld0wzL2dCcE1lWTNxR0ZL?=
 =?iso-2022-jp?B?dHhIUEF6dCtLaGlkQi9NVWVqdjBOcHFXTnBwMStjYjlGWXk4SW00UHcr?=
 =?iso-2022-jp?B?NlNMVUNpblEwRHd3UzQ3dXFpRFpLUDVkSVNPMmZ2R0pCb2Rvd0hRZEIy?=
 =?iso-2022-jp?B?Njg4QXhaSHlyM0o3S3djRDl1TklvYm4yNm9kQUpSZTNJcTZISlM3K3dM?=
 =?iso-2022-jp?B?dDkxcGFCMDU5aGhrTHFaem1WdjZsVG1DK1g0QVBhOTdqVGVDUUFiYkF6?=
 =?iso-2022-jp?B?S3hCU1I0cjF5QmRad0tUaXFsUjMydmc1OXg5ZDRDMS9lTnR5RVdrYkkr?=
 =?iso-2022-jp?B?ZDVZWGR6Zll4TUNaYmhEaXdTWmlxcU53N2QzbGR2RWZ6aVVNenEyWjhM?=
 =?iso-2022-jp?B?STZKYkw3UXZjUVd2YVhjdlEvVysvYzM5UkJzSjdRaDRIbFdhQVlacWpY?=
 =?iso-2022-jp?B?WGpsbGdtUG5JaE1pa0tVMXJoN1hicEZDWUgrNU9BeTJwa0FRTXF1TWtJ?=
 =?iso-2022-jp?B?RFE0UzdpczFaQVFxZVJzVHQzeXNoY3JsZ2pEdGEyR0Z0SkFPdWJYYVdX?=
 =?iso-2022-jp?B?citvWXJLUT0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB4600.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 297e360e-59fe-4b49-2e5f-08da1b95b7ae
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 08:31:47.1600
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Aj9IbwKSN13L2S9K/NubEqZkPDLWKZ/oDD/D705xtG21lDKuBYaGsnCyqBgZX2fMqvZVeRuUjOwgq2cqPzFsNBZMKecNGh4sB3GOUjg8HDM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8331
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi jirka

> On Fri, Mar 25, 2022 at 01:38:26PM +0900, Shunsuke Nakamura wrote:
> > Introduce perf_{evsel, evlist}__open_opt with extensible structure opts=
.
> > The mechanism of the extensible structure opts imitates
> > tools/lib/bpf/libbpf.h. This allows the user to set the open_flags
> > specified in perf_event_open and a signal handler to receive overflow
> > notifications for sampling events.
> >
> > Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> > ---
> >  tools/lib/perf/Documentation/libperf.txt |  14 +++
> >  tools/lib/perf/evlist.c                  |  20 +++++
> >  tools/lib/perf/evsel.c                   | 105
> +++++++++++++++++++++++
> >  tools/lib/perf/include/perf/evlist.h     |   3 +
> >  tools/lib/perf/include/perf/evsel.h      |  26 ++++++
> >  tools/lib/perf/internal.h                |  44 ++++++++++
> >  tools/lib/perf/libperf.map               |   2 +
> >  7 files changed, 214 insertions(+)
> >
> > diff --git a/tools/lib/perf/Documentation/libperf.txt
> > b/tools/lib/perf/Documentation/libperf.txt
> > index ae55e62fc4ce..700c1ce15159 100644
> > --- a/tools/lib/perf/Documentation/libperf.txt
> > +++ b/tools/lib/perf/Documentation/libperf.txt
> > @@ -131,6 +131,20 @@ SYNOPSIS
> >            };
> >    };
> >
> > +  struct perf_evsel_open_opts {
> > +          /* size of this struct, for forward/backward compatibility *=
/
> > +          size_t sz;
> > +
> > +          unsigned long open_flags;       /* perf_event_open flags */
> > +          int flags;                      /* fcntl flags */
> > +          unsigned int signal;
> > +          int owner_type;
> > +          struct sigaction *sig;
> > +  };
> > +  #define perf_evsel_open_opts__last_field sig
> > +
> > +  #define LIBPERF_OPTS(TYPE, NAME, ...)
> > +
>=20
> SNIP
>=20
> > +
> > +int perf_evsel__open_opts(struct perf_evsel *evsel, struct perf_cpu_ma=
p
> *cpus,
> > +			  struct perf_thread_map *threads,
> > +			  struct perf_evsel_open_opts *opts) {
> > +	int err =3D 0;
> > +
> > +	if (!OPTS_VALID(opts, perf_evsel_open_opts)) {
> > +		err =3D -EINVAL;
> > +		return err;
> > +	}
> > +
> > +	evsel->open_flags =3D OPTS_GET(opts, open_flags, 0);
> > +
> > +	err =3D perf_evsel__open(evsel, cpus, threads);
> > +	if (err)
> > +		return err;
> > +
> > +	err =3D perf_evsel__set_signal_handler(evsel, opts);
> > +	if (err)
> > +		return err;
>=20
> please move the signal stuff handling into separate patch together with t=
he
> related fields in opts struct
>=20
I'll fix it.


Best Regards
Shunsuke