Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp181990pxb; Mon, 11 Apr 2022 22:29:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcWcMP+pfKPpCwPDjaeIpfdUMRazmUTEev/wQNwBGf/oi+r8giAtuMjwaoqgWtHPZM16zw X-Received: by 2002:a17:906:7a51:b0:6e8:8e6c:f182 with SMTP id i17-20020a1709067a5100b006e88e6cf182mr8112163ejo.506.1649741358239; Mon, 11 Apr 2022 22:29:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649741358; cv=none; d=google.com; s=arc-20160816; b=j1U/b+opvwFCe3qjtJcXbN3O3bjjMAvNzHqv1FJzrTnIcD0HGAld5Qu+1A7K9M46kn 1IzkE6wRGnOA/y2QYR9c97Sf1sPWWSxzE55RvO42qm3n8uncA6nyQQdoDfNsyPuD4trA 8QVNSadfPB4JaTqxqX/jDKmIsQh75NsK3favl0MVL1njttLbfKBlbgV6OsY5ygEWbQsN sBtVyhZBdlWkWc1W/rEGAJL2ZipjjVo1WOuuFQstGTTowAPI7vmDDGCoQXp8015mnfUk QoTFqrwJDIfscWQGwunsqjMtMX6wlWVYnvP4ef9G9YXaotyoicnp/cWth/w1nSRRzXzh zmxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ct0KPIwIFBFQvI2RK89Mz30dFbD3GIANQnxanM+V5Hk=; b=VK2Wwrdzg+H8aCunUOiG4Hr8dJF9Nb4xLZREBXdAwfgYPebfMIIjfHrOJM0tA8A+7m rIyoXNe0TOQbNDI4VAnzN/Obe1afDdGGlpQTgL9Fi8jV27WU/Ew3t3yTAKUcvlFGUurB 3dX4IYRjKXq2Kx0QR1k/1BBTSj6GM+uUHM5BwpnwTIQ9FGKrpPw7VnrPluA9DDWa9J0a V6UAzFtSa9mLhUmV1KMi8ZaWSvZcrV0t8x6+7UhLLWJ6Rut7hhKFSOOl8mSK4KenOtAU KfbN2U32wMiJgYQY1Sd+q6+CFMx1WEGtm8izAXe8vGP18G6JNGjP6koghNZtDlKAaf+Y q0KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pIsrbL6u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r24-20020a1709064d1800b006e88cd8b684si4129052eju.727.2022.04.11.22.28.52; Mon, 11 Apr 2022 22:29:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pIsrbL6u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345916AbiDKLYD (ORCPT + 99 others); Mon, 11 Apr 2022 07:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345914AbiDKLX5 (ORCPT ); Mon, 11 Apr 2022 07:23:57 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB8445510 for ; Mon, 11 Apr 2022 04:21:43 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 32so11784147pgl.4 for ; Mon, 11 Apr 2022 04:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ct0KPIwIFBFQvI2RK89Mz30dFbD3GIANQnxanM+V5Hk=; b=pIsrbL6usz31jkne7q1tPeu0ne1pxxjoT9uAJd0h3YObyCn1tzb/VLB/xZdUVld6lS nNppWDpT6aGeR9pBBW8TIQgIbbS61uE0mv5TMr3iN7jRsITnU0mkdH9BIz8Ty+wjFg6y x8syGq/uRIQ4F/KNpRE4sOwmu7HvaNg+Jb/ZEJNCQTiRc1a6IVDotCUiutJnP2kiVnuc 7VFRyA862wDCxEU5N21FTg3TwaeC6Oynh/oJrndTiubYW/l0WIizvOYjqtZQTblopDU9 do18EQGK8mjffeEdwBfZX/W8l0g4aE9zgrQ8LSTs9qN2BjDBsYSC3nzqBb7HrbnB46NE I04w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ct0KPIwIFBFQvI2RK89Mz30dFbD3GIANQnxanM+V5Hk=; b=Kg9mEK/O7/dBFXqXxeXHRyIyrgee/rSGHndUBdpbhaE+0vjnqxmWO2PxN4U5dn1YEE yL1mzHl0i93lHI8UPIPogj80eO6oSFRCjPXtw0b/JrOvDVBmHmnuLQgbiqAG5g4dywfz bTQz2Z1OOYO6pBV6TYPTg6XZqdmJP6sHIHNgeRzIwffSFWs+6uG+vrBeUVH98sIjW+W9 ZZfIqmttMPQjFTKf2Mfw4wCjvxoaD2MSwuToneuKtCQIwE24FCB+qnihg4COeb5rrOqR JZHzHVmW4REmqAprGclmRQ0qY4f2y2Bhx63MlPYN0N8es8+MZIDaH+oWh7p0EWw/yFoY WW6A== X-Gm-Message-State: AOAM530pENxlkq9DhsRfL7cLnV5z9609elN2jVj0/gvHQ74RuBu73JX2 a1QmFvV4vECYTj1QoKu9ww== X-Received: by 2002:a63:5f42:0:b0:39d:4f86:2f59 with SMTP id t63-20020a635f42000000b0039d4f862f59mr4132369pgb.181.1649676102588; Mon, 11 Apr 2022 04:21:42 -0700 (PDT) Received: from localhost.localdomain ([144.202.91.207]) by smtp.gmail.com with ESMTPSA id y3-20020a63de43000000b0039d1172b90fsm7365844pgi.76.2022.04.11.04.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 04:21:42 -0700 (PDT) From: Zheyu Ma To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Zheyu Ma Subject: [PATCH] mtd: rawnand: Use managed device resources Date: Mon, 11 Apr 2022 19:21:24 +0800 Message-Id: <20220411112124.3700126-1-zheyuma97@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All of the resources used by this driver has managed interfaces, so use them. Otherwise we will get the following splat: [ 4.472703] denali-nand-pci 0000:00:05.0: timeout while waiting for irq 0x1000 [ 4.474071] denali-nand-pci: probe of 0000:00:05.0 failed with error -5 [ 4.473538] nand: No NAND device found [ 4.474068] BUG: unable to handle page fault for address: ffffc90005000410 [ 4.475169] #PF: supervisor write access in kernel mode [ 4.475579] #PF: error_code(0x0002) - not-present page [ 4.478362] RIP: 0010:iowrite32+0x9/0x50 [ 4.486068] Call Trace: [ 4.486269] [ 4.486443] denali_isr+0x15b/0x300 [denali] [ 4.486788] ? denali_direct_write+0x50/0x50 [denali] [ 4.487189] __handle_irq_event_percpu+0x161/0x3b0 [ 4.487571] handle_irq_event+0x7d/0x1b0 [ 4.487884] handle_fasteoi_irq+0x2b0/0x770 [ 4.488219] __common_interrupt+0xc8/0x1b0 [ 4.488549] common_interrupt+0x9a/0xc0 Fixes: 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir") Signed-off-by: Zheyu Ma --- drivers/mtd/nand/raw/denali_pci.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c index 20c085a30adc..de7e722d3826 100644 --- a/drivers/mtd/nand/raw/denali_pci.c +++ b/drivers/mtd/nand/raw/denali_pci.c @@ -74,22 +74,21 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) return ret; } - denali->reg = ioremap(csr_base, csr_len); + denali->reg = devm_ioremap(denali->dev, csr_base, csr_len); if (!denali->reg) { dev_err(&dev->dev, "Spectra: Unable to remap memory region\n"); return -ENOMEM; } - denali->host = ioremap(mem_base, mem_len); + denali->host = devm_ioremap(denali->dev, mem_base, mem_len); if (!denali->host) { dev_err(&dev->dev, "Spectra: ioremap failed!"); - ret = -ENOMEM; - goto out_unmap_reg; + return -ENOMEM; } ret = denali_init(denali); if (ret) - goto out_unmap_host; + return ret; nsels = denali->nbanks; @@ -117,10 +116,6 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) out_remove_denali: denali_remove(denali); -out_unmap_host: - iounmap(denali->host); -out_unmap_reg: - iounmap(denali->reg); return ret; } @@ -129,8 +124,6 @@ static void denali_pci_remove(struct pci_dev *dev) struct denali_controller *denali = pci_get_drvdata(dev); denali_remove(denali); - iounmap(denali->reg); - iounmap(denali->host); } static struct pci_driver denali_pci_driver = { -- 2.25.1