Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Apr 2022 14:47:13 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Zheyu Ma <zheyuma97@gmail.com>
Cc:     richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: Use managed device resources
Message-ID: <20220411144713.3057dd17@xps13>
In-Reply-To: <20220411112124.3700126-1-zheyuma97@gmail.com>
References: <20220411112124.3700126-1-zheyuma97@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

zheyuma97@gmail.com wrote on Mon, 11 Apr 2022 19:21:24 +0800:

Prefix should be "mtd: rawnand: denali:"

> All of the resources used by this driver has managed interfaces, so use
> them. Otherwise we will get the following splat:
>=20
> [    4.472703] denali-nand-pci 0000:00:05.0: timeout while waiting for ir=
q 0x1000
> [    4.474071] denali-nand-pci: probe of 0000:00:05.0 failed with error -5
> [    4.473538] nand: No NAND device found
> [    4.474068] BUG: unable to handle page fault for address: ffffc9000500=
0410
> [    4.475169] #PF: supervisor write access in kernel mode
> [    4.475579] #PF: error_code(0x0002) - not-present page
> [    4.478362] RIP: 0010:iowrite32+0x9/0x50
> [    4.486068] Call Trace:
> [    4.486269]  <IRQ>
> [    4.486443]  denali_isr+0x15b/0x300 [denali]
> [    4.486788]  ? denali_direct_write+0x50/0x50 [denali]
> [    4.487189]  __handle_irq_event_percpu+0x161/0x3b0
> [    4.487571]  handle_irq_event+0x7d/0x1b0
> [    4.487884]  handle_fasteoi_irq+0x2b0/0x770
> [    4.488219]  __common_interrupt+0xc8/0x1b0
> [    4.488549]  common_interrupt+0x9a/0xc0
>=20
> Fixes: 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ s=
ubdir")
>=20

Extra space

> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>

Otherwise LGTM.

> ---
>  drivers/mtd/nand/raw/denali_pci.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/den=
ali_pci.c
> index 20c085a30adc..de7e722d3826 100644
> --- a/drivers/mtd/nand/raw/denali_pci.c
> +++ b/drivers/mtd/nand/raw/denali_pci.c
> @@ -74,22 +74,21 @@ static int denali_pci_probe(struct pci_dev *dev, cons=
t struct pci_device_id *id)
>  		return ret;
>  	}
> =20
> -	denali->reg =3D ioremap(csr_base, csr_len);
> +	denali->reg =3D devm_ioremap(denali->dev, csr_base, csr_len);
>  	if (!denali->reg) {
>  		dev_err(&dev->dev, "Spectra: Unable to remap memory region\n");
>  		return -ENOMEM;
>  	}
> =20
> -	denali->host =3D ioremap(mem_base, mem_len);
> +	denali->host =3D devm_ioremap(denali->dev, mem_base, mem_len);
>  	if (!denali->host) {
>  		dev_err(&dev->dev, "Spectra: ioremap failed!");
> -		ret =3D -ENOMEM;
> -		goto out_unmap_reg;
> +		return -ENOMEM;
>  	}
> =20
>  	ret =3D denali_init(denali);
>  	if (ret)
> -		goto out_unmap_host;
> +		return ret;
> =20
>  	nsels =3D denali->nbanks;
> =20
> @@ -117,10 +116,6 @@ static int denali_pci_probe(struct pci_dev *dev, con=
st struct pci_device_id *id)
> =20
>  out_remove_denali:
>  	denali_remove(denali);
> -out_unmap_host:
> -	iounmap(denali->host);
> -out_unmap_reg:
> -	iounmap(denali->reg);
>  	return ret;
>  }
> =20
> @@ -129,8 +124,6 @@ static void denali_pci_remove(struct pci_dev *dev)
>  	struct denali_controller *denali =3D pci_get_drvdata(dev);
> =20
>  	denali_remove(denali);
> -	iounmap(denali->reg);
> -	iounmap(denali->host);
>  }
> =20
>  static struct pci_driver denali_pci_driver =3D {


Thanks,
Miqu=C3=A8l