Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220409042321.3184493-1-james.hilliard1@gmail.com>
 <CAMeQTsanEow=zq=MuZLjMqpzybdS=5S0=JrkxuCdT7d5MxpEWQ@mail.gmail.com>
 <CADvTj4rBKzGFch8iVzHu1s+6=P0PcLEwoFi74xd_ormEX+2rMA@mail.gmail.com>
 <CAMeQTsaM363n5F=--xhSTayFqOMNvjTQjqz_aEhby6i-KRVBKQ@mail.gmail.com> <CADvTj4o_zyVZxaBz0+kRUF30OW3SKFMuo87r6FE9Qkfn1dVsBw@mail.gmail.com>
In-Reply-To: <CADvTj4o_zyVZxaBz0+kRUF30OW3SKFMuo87r6FE9Qkfn1dVsBw@mail.gmail.com>
From:   Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Date:   Mon, 11 Apr 2022 11:27:43 +0200
Message-ID: <CAMeQTsbKMxQcDsDRqHsMwqU1BnrcOLwtU7uOrB-1E0z65P79-w@mail.gmail.com>
Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer
To:     James Hilliard <james.hilliard1@gmail.com>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Apr 10, 2022 at 10:05 PM James Hilliard
<james.hilliard1@gmail.com> wrote:
>
> On Sun, Apr 10, 2022 at 1:52 PM Patrik Jakobsson
> <patrik.r.jakobsson@gmail.com> wrote:
> >
> > On Sun, Apr 10, 2022 at 9:40 PM James Hilliard
> > <james.hilliard1@gmail.com> wrote:
> > >
> > > On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson
> > > <patrik.r.jakobsson@gmail.com> wrote:
> > > >
> > > > On Sat, Apr 9, 2022 at 6:23 AM James Hilliard <james.hilliard1@gmail.com> wrote:
> > > > >
> > > > > Select the efi framebuffer if efi is enabled.
> > > > >
> > > > > This appears to be needed for video output to function correctly.
> > > > >
> > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > >
> > > > Hi James,
> > > > EFI_FB is its own driver and not needed by gma500 to drive its
> > > > hardware. What makes you think it's required?
> > >
> > > I wasn't getting any HDMI video output without it enabled for some reason,
> > > I assume it is doing some sort of initialization needed by gma500
> > > during startup.
> >
> > Then it sounds like you might just be using EFI_FB and not gma500. Can
> > you provide the kernel log with drm.debug=0x1f set on kernel
> > command-line.
>
> Seems efifb loads first and then hands off to gma500

That is how it normally works but efifb shouldn't change the state of
the currently set mode so shouldn't affect gma500.
From the logs I can see that you have LVDS (internal panel), HDMI and
DP (3 displays in total) connected. This sounds wrong. Your version of
gma500 (Cedarview) doesn't support more than 2 crtcs/pipes. This might
be a problem.