Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "nakamura.shun@fujitsu.com" <nakamura.shun@fujitsu.com>
To:     'Jiri Olsa' <olsajiri@gmail.com>
CC:     "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@redhat.com" <jolsa@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>
Subject: RE: [RFC PATCH v2 4/7] libperf: Introduce perf_{evsel,
 evlist}__open_opt with extensible struct opts
Thread-Topic: [RFC PATCH v2 4/7] libperf: Introduce perf_{evsel,
 evlist}__open_opt with extensible struct opts
Thread-Index: AQHYRD0mlfomz6jCoE+uLALkEGmIQ6zqdMUA
Date:   Mon, 11 Apr 2022 08:34:09 +0000
Message-ID: <OSBPR01MB46001064CFA2AF85C1D161B8F7EA9@OSBPR01MB4600.jpnprd01.prod.outlook.com>
References: <20220325043829.224045-1-nakamura.shun@fujitsu.com>
 <20220325043829.224045-5-nakamura.shun@fujitsu.com> <YkRgM1obkBQsY2FR@krava>
In-Reply-To: <YkRgM1obkBQsY2FR@krava>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?enNqN3Rla2pBRWdON1ZCMlJ5TmNxemFhdjZ4QUlnWFpsQVBSMGszZEFi?=
 =?iso-2022-jp?B?V0N4S1JxSXUxd3NQOUk0WWVKVzBiWmh3WWVMR1VsSURjWWFhcUZWTWhR?=
 =?iso-2022-jp?B?R3MrN0owZzdIMGVxRGg0WDVuNW9sUEZHZDRaeW4zUW15b1RQSmpBK3BM?=
 =?iso-2022-jp?B?cWt4ZmFLRlE2Smp6ZnQ3dkdLVG8wVkVuK3NnVkNkWjJuSkM5TzBCWDVy?=
 =?iso-2022-jp?B?R0prZDhMQWRxekxDTTgrcmVPSlgxSkpDNlVOY1QrNU9hczNXSHVPcWlt?=
 =?iso-2022-jp?B?TW4zeFBVSEZoOGJmbTRoa2R1dE52QkU2cXBOU0xaZWI4V3dPeWNwK2RL?=
 =?iso-2022-jp?B?c1cwdTJvbjhSdVNzaThUMjJIMFZuM2ZFYmpPNlF0b3o2eXR3YWtubHN3?=
 =?iso-2022-jp?B?M1cwNjNlUTNSUDVsUTdJdkZmdnRuVHd1d1BPcFhnT0tQOEkrOExSbzBT?=
 =?iso-2022-jp?B?akxoQWc0OHJtUVFTTHpmMVYvZFdtcFFLenhtZ1ppdWdpUWFxVlI0QVhr?=
 =?iso-2022-jp?B?ODFNcFA3d2lueXMvL0dlV1pVNUY3YVFsdDcxOTNYRTNRRnF6MnA5S1ds?=
 =?iso-2022-jp?B?NW9uQnB4Z1BhSDVEQ2xxaU9TNnVWUWp1UnVEU1R1SU5lMzh6bDVqZGds?=
 =?iso-2022-jp?B?MWNhU242L002QVA2dVVIeUdCbFdzLzZFcFRGeGFPRWJpU3hJOWNyL2h1?=
 =?iso-2022-jp?B?UUtRajBITG0vZlV2dkUzb3pidDU2YVRCQkFrcDJva2xSWDEvdjQ1dGZp?=
 =?iso-2022-jp?B?czV6QWpSZkFoQVAveEJJRTNMNlc0RVJ1MWtIL29jbDl0ZFhuTG13bENV?=
 =?iso-2022-jp?B?R0xBRWRESit4WjlnRHZibktuQUpOUkpEbFJjSGFndUtITzdMOWJ2d2Ny?=
 =?iso-2022-jp?B?MmxLQzh0WEVPVitMdlZ4d2kxbWN4Mkg0UGdKVXRtQ3FSY1FRMnUwYVla?=
 =?iso-2022-jp?B?VUx2bHd2K0o1Nk5TUm42TEJua2NaY21mRk50UWhZOERSemd4WFd4MEJP?=
 =?iso-2022-jp?B?MUw4Y0tSa0NWV1ljby9GUC9KRFljb004R1JoRmpXZzNmdTlQcVU3THUz?=
 =?iso-2022-jp?B?MCtwM1NGQlhsekc5V3JMenFjbkJIQUlSZlAyYnVtUWN0TytPbHdvSFMx?=
 =?iso-2022-jp?B?K1V2ZkFsa2tpMmN1bE1FNHZIYThyRVpiR2FoUWNjbXpNajg2dSs4dzV1?=
 =?iso-2022-jp?B?eUgzNldxMjZKUDFiMUp0Z1NacEh4QUhaWk9KNUlzNkU2ZnRFbFVJMVkr?=
 =?iso-2022-jp?B?d2I4YTN1UzVJVFdoNzNHU3k4cmlRb3B1NXQ4WmdCUUUwUFcwR3VhemlP?=
 =?iso-2022-jp?B?Vjc1Nm9aeFcwdEpnS0hvUWdpRGpOS0g0ZCt1UWRhM3hBaE1FY3NqZitr?=
 =?iso-2022-jp?B?NjlGZ1BvSVBEWjduQUVuOFpVODhPT08rK3ZCOUdjSnVwaUhMbHYreUg2?=
 =?iso-2022-jp?B?T2hTd1N4VGxaS1dlaG84T1RSNHZ6bFRDWmIyK1oxdGI1R2MyVG9JUUJL?=
 =?iso-2022-jp?B?ZFVKWmxKRC9aUmhrZC9hWm4wM09zNStMUkRFaG9NYlRjSFByUWhLT0Fl?=
 =?iso-2022-jp?B?NnZGUG9raXdEdTI0Q0NKRHJ4N1Y4aGdDZ1ZnZmN0MlpEU2pDSE4zcW1P?=
 =?iso-2022-jp?B?N09WUmxGdkhGcXpsSG1hL1NDb0czdHpBVDU1MEEvZzZ6TjJDdVI4OHFx?=
 =?iso-2022-jp?B?WlhsdlhNVEhsbW1kTThZVXlDTmpSWjUveUFGTENwMFFqZUdYRHFRblVj?=
 =?iso-2022-jp?B?akdZZlA0a0d3b2V3amhTNXlleDhJL0ovcmNnUW5HV2dqUU53SjkwUUlP?=
 =?iso-2022-jp?B?UHJxK2o2alducVdpRkQveEtyKy94d1RKYnNLVHZJVzBNRGwrblRUN0RQ?=
 =?iso-2022-jp?B?ZE4ycTZNT01wWS94QXBBblA4dHpZWnNXUHlsRitOcit6M0pMYTVFV2Rh?=
 =?iso-2022-jp?B?VFVXR0YyWldkL0pldnd4a2Fua2FxbUlxcEpGRUQxRVVkTUJQWjkzajB2?=
 =?iso-2022-jp?B?YkpiaDRRVnBJNXpxMkYyMW15NEVqQmVlUnJYUXh4Z0RUYjRGc0l0V3Rr?=
 =?iso-2022-jp?B?aFFhSVQxOFYraWV0VEFYVENTcTNIamlJVVlXRWQ4VE4rSXRDNFdzNWMz?=
 =?iso-2022-jp?B?ZG5wSisxZ1R1MjBOU3ZiN3d0MVkrVlppWmoydnBFUzlydDNWYUJVdk5y?=
 =?iso-2022-jp?B?Zmp1bVpvcDZLYk5mcEVrVUpLOTBRTCtNNnNnem1ibXVrbEpXYk1hVzkz?=
 =?iso-2022-jp?B?cGs4ajhhTUpHdFFFUWM2RlpWTjJlbHNwUUpFOC9RU09vYWg3Tnp2UDVZ?=
 =?iso-2022-jp?B?OGZzMERoWHZ0VlpBZVJid250SGZETlJ3RXBqSHZiWlc5ald2QzhMRlRO?=
 =?iso-2022-jp?B?dThWMGF2VUZUUjJOQjJLL1FkaUZhYSt6M1VpR0xBV240bjAyS2JTQytJ?=
 =?iso-2022-jp?B?MDFKdmFhWlh5ZlZvV0o0T0pCdFRsYmNuaFVBTTMvRE83YUU2QmZ6NEla?=
 =?iso-2022-jp?B?OGFGaC85VWpsTHBhd0ZhZTBPdnpOUGZWUTRTRG5CSDZmdzZta2xVMDdR?=
 =?iso-2022-jp?B?aC8rL3U1OD0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB4600.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d275daea-98a7-471f-cc59-08da1b960c9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 08:34:09.6343
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J4cW/oWuRuePfUbW0jhtchO7pbfZoAgIchaEhuh2p3tdm/cT/633SXC9xw+L9RdNmjLzVwjaAvJzXlhfxa3SDuYGdfpcylftqT5bfy8OCSU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB3316
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi jirka

> On Fri, Mar 25, 2022 at 01:38:26PM +0900, Shunsuke Nakamura wrote:
>=20
> SNIP
>=20
> > diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c index
> > b17842581dea..db9b7274feb5 100644
> > --- a/tools/lib/perf/evsel.c
> > +++ b/tools/lib/perf/evsel.c
> > @@ -1,4 +1,7 @@
> >  // SPDX-License-Identifier: GPL-2.0
> > +#ifndef _GNU_SOURCE
> > +#define _GNU_SOURCE
> > +#endif
>=20
> I think we can make this global set in Makefile, like we do in perf
>=20
I'll fix it.


Best Regards
Shunsuke