Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <25390602-cfa0-dba3-bfbc-a35ed6b44bcf@kernel.dk>
Date:   Fri, 8 Apr 2022 06:34:04 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] cdrom: do not print info list when there is no cdrom
 device
Content-Language: en-US
To:     Enze Li <lienze@kylinos.cn>, phil@philpotter.co.uk
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
References: <20220408084221.1681592-1-lienze@kylinos.cn>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220408084221.1681592-1-lienze@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/8/22 2:42 AM, Enze Li wrote:
> There is no need to print a list of cdrom entries with blank info when
> no cdrom device exists.  With this patch applied, we get:
> 
> ================================================
> $ cat /proc/sys/dev/cdrom/info
> CD-ROM information, Id:cdrom.c 3.20 2003/12/17
> 
> No device found.
> 
> ================================================

And what did we get before?

Will this potentially break applications that parse it?

-- 
Jens Axboe