Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 9 Apr 2022 17:08:37 +0300
From:   Maxim Devaev <mdevaev@gmail.com>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Cai Huoqing <caihuoqing@baidu.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: break IO operations via
 configfs
Message-ID: <20220409170837.02f0853f@reki>
In-Reply-To: <YlGOOJ9SwkD7WVmX@rowland.harvard.edu>
References: <20220406092445.215288-1-mdevaev@gmail.com>
        <Yk2wvhSTMKTLFK6c@rowland.harvard.edu>
        <20220406195234.4f63cb4a@reki>
        <Yk3TLPKyaQDsnuD4@rowland.harvard.edu>
        <20220406213634.104cae45@reki>
        <Yk8L6b9wEWTjWOg4@rowland.harvard.edu>
        <20220407204553.35cead72@reki>
        <YlBN4Zcn9NYw0PLA@rowland.harvard.edu>
        <20220409115756.4f9b015d@reki>
        <YlGOOJ9SwkD7WVmX@rowland.harvard.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=D0=92 Sat, 9 Apr 2022 09:46:32 -0400
Alan Stern <stern@rowland.harvard.edu> wrote:

> On Sat, Apr 09, 2022 at 11:57:56AM +0300, Maxim Devaev wrote:
> > =D0=92 Fri, 8 Apr 2022 10:59:45 -0400
> > Alan Stern <stern@rowland.harvard.edu> wrote: =20
> > > > At least there is one situation where the behavior of f_mass_storag=
e differs
> > > > from the behavior of a real drive. What happens when you click on t=
he physical
> > > > "eject" button?   =20
> > >=20
> > > If the host has prevented ejection, nothing happens.  Otherwise the d=
isc=20
> > > gets ejected.
> > >  =20
> > > > Yes, the OS can block this, but the problem is that we don't have
> > > > an "eject" here.   =20
> > >=20
> > > What do you mean?  Writing an empty string to the sysfs "file" attrib=
ute=20
> > > is the virtual analog of pressing the eject button. =20
> >=20
> > But I can't eject the disc event it's not mounted on Linux host. It see=
ms to me
> > it differs from the real drive behavior. =20
>=20
> It sounds like either there's a bug or else you're not doing the right=20
> thing.  Tell me exactly what you do when this fails.

I'm using Raspberry Pi with DWC2. So:
- Connect RPi-based gadget to the Linux host.
- Set image in the "file" attribute.
- Mount gadget's drive on the Linux host.
- Umount it.
- Try to eject using emptying the "file" attribute.
- Get EBUSY error.

>=20
> > > ... =20
> >=20
> > I have reflected on the rest of your arguments and changed my mind.
> > I think that "forced_eject" for a specific lun without interrupting ope=
rations would
> > really be the best solution. I wrote a simple patch and tested it, ever=
ything seems
> > to work. What do you think about something like this?
> >=20
> >=20
> > static ssize_t fsg_lun_opts_forced_eject_store(struct config_item *item,
> >                                                const char *page, size_t=
 len)
> > {
> >         struct fsg_lun_opts *opts =3D to_fsg_lun_opts(item);
> >         struct fsg_opts *fsg_opts =3D to_fsg_opts(opts->group.cg_item.c=
i_parent);
> >         int ret;
> >=20
> >         opts->lun->prevent_medium_removal =3D 0;
> >         ret =3D fsg_store_file(opts->lun, &fsg_opts->common->filesem, "=
", 0);
> >         return ret < 0 ? ret : len;
> > }
> >=20
> > CONFIGFS_ATTR_WO(fsg_lun_opts_, forced_eject); =20
>=20
> The basic idea is right.  But this should not be a CONFIGFS option; it=20
> should be an ordinary LUN attribute.  For an example, see the definition =
of=20
> file_store() in f_mass_storage.c; your routine should look very similar.

Okay, but where this attribute is located in sysfs? How can I use it?
Sorry for the stupid question.