Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <860537a5-5fab-602d-1e00-a84903084383@amd.com>
Date:   Mon, 11 Apr 2022 08:58:04 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Cc:     brijesh.singh@amd.com, bp@suse.de
Subject: Re: [PATCH -next] virt: sevguest: Fix return value check in
 alloc_shared_pages()
Content-Language: en-US
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org
References: <20220411111213.1477853-1-yangyingliang@huawei.com>
From:   Brijesh Singh <brijesh.singh@amd.com>
In-Reply-To: <20220411111213.1477853-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zk1mbDVDek1ySHNsVmRJeWh1WEUrMzIrbzc1cTdSd0FVMUUxWmNzcDVjV3ZX?=
 =?utf-8?B?UGlodjcrVWFGcUZpR01oZi93SzBnbzVNV0l2Uzgwc3lvMXZNeGJwRXV6U3p6?=
 =?utf-8?B?d3puN3FxL05sVjREYTJrU0VCb1NWWHhBTFF6eG81T1ZzSnhBTUszd1I5MnY2?=
 =?utf-8?B?Mkt2c1MwK0tPeE1EWjIrSUF5anJZWWloRUgxaC8yNnVNTmRZU0t4eGRqd2w0?=
 =?utf-8?B?VjZHVGh1MzhjNHhvN3RPZ3dXU2p1WXo3ZlNWbzVPb0daV1RPbmtYUkdXcld6?=
 =?utf-8?B?WlQyRWdGdkRnMnhYcGV3ZzcrYm83T3hJZ08yb2tzQWRVS2xsOWhMUjR3VURJ?=
 =?utf-8?B?TlgrYnFlWTUrVUs2RW9vK0VLc0dqZjVka0pnQk02OHE1am8weTc2dWlkWnln?=
 =?utf-8?B?MzlGcVZSWVpaRnpuR2xQenNvOVJTTEozN0YybVBCN2h0cGFQRjFXNEU1Q0ZJ?=
 =?utf-8?B?ZTEvTUYrdFo0NjhPVitDOFhHdTF6akJnVFlPV2xIK0RQNEN3SXM0aTdqTVk3?=
 =?utf-8?B?Q0plTGtsT1NreE9nYUx3Qk1RZ2NDQ2phdmsvbWZUdzZuQjJhK1lpelNkMzhs?=
 =?utf-8?B?T0laV083elp5cCtBQUJoZVF5ZlZFVkdYYWFTWEU3VFYvbzdYRE9hY3dCR2Mx?=
 =?utf-8?B?SXJMY0p1R1Y2dHhZc05xb1Z3cUhObnMvWENOVWF0WTg1YjRDYm9ZejI3U3RF?=
 =?utf-8?B?YUQ5S0cyUkNCTSt5Q3o2MFFBcUxQRkpJVXpBY0NDeGU3Qlp4aEFCWm43VjZQ?=
 =?utf-8?B?M2pGQ0RSbzkwYk1iZ2RVQ1NTcE9PQ3F5UVgzU1R4VmFPc293UGd0b1ByRXpP?=
 =?utf-8?B?TURVOWQ0enUrSHNiSitsaktvcEQ5UnBWRzljS1VUOGExdTJ6WXlEemtIQjhM?=
 =?utf-8?B?eVEzajk5RFVCa3JsclVESjlSMTFQWHp2NXZjUkRVV0Z0VW9IVXRhRGZpMDZI?=
 =?utf-8?B?NzlsOVZvUS9EQmtET3ByVU04dUVaNGNiRTh2YlNyUUx1ZDBJd2VtV2xiQncr?=
 =?utf-8?B?SXRuWGFZcGZMcXFMM1ZJS3BXM29SNy9xd2oyN2xra1Z3Uzk2NktpTEtDY3Ar?=
 =?utf-8?B?QkRPbW55ODlvQ3RkZE1Oa3MxQUJLbkdSRUNISDNDTHYzUGpuam5ocVRyTjdn?=
 =?utf-8?B?c2pSQ3EyU0x0VnJWci9hbXhwWnJEMVl4SGRPcHQ2ZXBqajFFdVVTck4zMExq?=
 =?utf-8?B?L3ZXZEZmTGJJcDNUZEpkTWozR1FOUXlYcDc1WVhhVStNYXRRN3REUGRrcitO?=
 =?utf-8?B?MS9VeTBhYlFpUUQ1aWNwQU9JNHlsSHRkL1RSWS83WmRObFdEMFVsc3VPeGM1?=
 =?utf-8?B?SGpvM0FVL0g5b2RXNk1XVjh3UzhTUmoxMjJ4ZEd5Q2t1V1MrNnJ0aUg4cTFi?=
 =?utf-8?B?ekNyNFZZZkpKMDF3MDhlUklUbEEveWI3TFpFZnRTeDdNTkE3NENoc2VBNTl3?=
 =?utf-8?B?THo3eTBUclVkYllLcVlrVE5NRlI1dXFBRXVXZzlVRHl6bGVDL0ZnOExBb1A4?=
 =?utf-8?B?dWdqWnhMb0tnVUJGZ1pxY0QwbHh4U0hVdCtkeUNGMWxzNlBlVDB4V29HQ01H?=
 =?utf-8?B?NkIxNDZhNk9sSXBwU1R0SXR4ajJtbDN4bkxrY2M1bll1SC9jWU9BRWgzcDJV?=
 =?utf-8?B?NmJkT3BWTG5HaVQxUjF6b2dLcGlkNmZuNXUxTm01Wm1TZk1WVDFadzVMaU1l?=
 =?utf-8?B?djlYWmczYlZNRkxBN1lwc0RUbnozRUVVWGtVTEtjZFlaelFGdERzbVFVRHVO?=
 =?utf-8?B?NkExUE0zcTV3UWVUeFd2dzRZRTVzUFFRZjhhNkpNdURBLzArU1BRNWxuQlVY?=
 =?utf-8?B?ZXFmMkJKQzBUMUpyTDRKS3BQWisyNVhTVFBvZnB5ZFNqT1dpMkpWQzdsdnp0?=
 =?utf-8?B?R0k3MCtSYkNxM2RQaVRhSzNob2UzczJjcE5tbDU3THltN2hNQW44a3laZmxI?=
 =?utf-8?B?NzZNdWh3R3Q0bTlrejNzZVpGU1cweURkL2dGVklQTG1WMVVJdnFpQnJkOS82?=
 =?utf-8?B?Ly9FSlBIa1ZaelhPTnRhMDlUYmxEamlFUnNzelAzSUZYMW9BY1lDUzVvY29B?=
 =?utf-8?B?OWIyakxsWWIrekkwbWlqbUc0bm04cHNubUt5WVIrRGhUSjkweHpvOWlqZUpC?=
 =?utf-8?B?b0ZSWkV4YlVBMDlWU3BpTHBNVVB0V1NBQkdGOXBPTm1KemZvVXVDZkY5Y3BP?=
 =?utf-8?B?WFkwQWQxcHo5bzl4ZUlaK3Z6ODhGMkNIbmxMOGlzMURtZVYxQTJJOEVBTFR2?=
 =?utf-8?B?Sk5rVDlCanJwWTdwcU5rdVNjdVJlaE83aFk4YUs0V1JKa05leXdueWxodHhU?=
 =?utf-8?B?cXc5UThKVjhGYkpnMG9YdFF6Wkdaa1BwMWxvN1pxejNDZTUxdmFkUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ca867ea-9b81-44b8-62cd-08da1bc34e4b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 13:58:07.5138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 13xNj8SSlvfmcuBWuGKCAW9jGtUgGnHdCetpmlWEN4eWwL3rAqB0hceMlJvJJZxg+n7RQQjoff9V5kGYZRJjyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4039
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/11/22 06:12, Yang Yingliang wrote:
> If alloc_pages() fails, it returns NULL pointer, replaces
> IS_ERR() check with NULL pointer check.
> 
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>

thanks