Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220409144239.2649257-1-jsyoo5b@gmail.com>
In-Reply-To: <20220409144239.2649257-1-jsyoo5b@gmail.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Mon, 11 Apr 2022 11:50:14 +0800
Message-ID: <CAMZfGtXH_AdzSea6eTJk==LQXB40iN0wFP6cry8=OpDGgY0dtg@mail.gmail.com>
Subject: Re: [PATCH] mm/slub: remove meaningless node check in ___slab_alloc()
To:     JaeSang Yoo <js.yoo.5b@gmail.com>
Cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Ohhoon Kwon <ohkwon1043@gmail.com>,
        Wonhyuk Yang <vvghjk1234@gmail.com>,
        Jiyoup Kim <lakroforce@gmail.com>,
        Donghyeok Kim <dthex5d@gmail.com>,
        JaeSang Yoo <jsyoo5b@gmail.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Apr 9, 2022 at 10:43 PM JaeSang Yoo <js.yoo.5b@gmail.com> wrote:
>
> node_match() with node=NUMA_NO_NODE always returns 1.
> Duplicate check by goto statement is meaningless. Remove it.
>
> Signed-off-by: JaeSang Yoo <jsyoo5b@gmail.com>

LGTM.

Reviewed-by: Muchun Song <songmuchun@bytedance.com>