Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 10 Apr 2022 13:04:44 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        bilbao@vt.edu
Subject: Re: [PATCH 1/2] x86/mce: Simplify AMD severity grading logic
Message-ID: <YlLV7FKJZgrKOY9Z@yaz-ubuntu>
References: <20220405183212.354606-1-carlos.bilbao@amd.com>
 <20220405183212.354606-2-carlos.bilbao@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220405183212.354606-2-carlos.bilbao@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MNE+Ooe+LlV210gyUBsCwLs63aRJP6vZcALjCdXo/kApbb4J/0nGnYIGFHTv?=
 =?us-ascii?Q?zPYk6qrZ1fAcuI7/XZukbd+6tBLYhCG6PaCoey323C9PySFdF3WiADxpDM2e?=
 =?us-ascii?Q?nsk3lL4BzXmXM4BqoatoNSvB5CvvGv5OzDACOcDxBzednVSTompwhQtw3Eya?=
 =?us-ascii?Q?K2VwttemQpWlZLT4YM/jFPIpiLi2xYtytVw+AJjoulnfIrpBiyn9M+uU4+PC?=
 =?us-ascii?Q?blc8Eq5PW45E63CYRvanmNMmqLYKdqFDuOyI/csJ/SA4L9vDgMZfTSJQgn9p?=
 =?us-ascii?Q?GWk0ZM42z3AAMEWZ/idXLqVQs/z8vLD90JlGgkJBrUE4Htk2jxXTyq3oqYPa?=
 =?us-ascii?Q?OXvjBCSPIdyMPyKJ/ICZDxEn14Ap7/vYOPhRH5DqBw6ztOz3U2PuP+p9izcW?=
 =?us-ascii?Q?rjsJPVd71PWzplJ0te8/5YCUTofU7T7VSF1xG8hPEH14Ky+/ek/W8TDgX3eE?=
 =?us-ascii?Q?6TBjdzOLnhWPZjGatfT5s3n6sj/+21QF/9UU+mvfUCCzjXTXHyLRRZmQXvp9?=
 =?us-ascii?Q?CB0KmMuIDPlKXxJUvSj0csBNi214zZDEtSKBX/0yZsCMjo7qM1qkxZZaNyF2?=
 =?us-ascii?Q?WyuD+uUZRE17s4MGMJ+NgboAPpUu4EoBi431czWZr/nbslnppfMwvsVcdClu?=
 =?us-ascii?Q?EIgN9Vds0+doTlv6ui/FUo8/llgY2LQ8SBZeDVVXHyDvsQsR7g00ujUsMIw5?=
 =?us-ascii?Q?Uyz1cncI7KVurPYsZgeEj6NSrN646Wb1gH/2XaZPrDxkjhrhNPZNwwJRuAZj?=
 =?us-ascii?Q?iLdqKQUBsPEfSMzPSpJxYyysdD/2VsfVPDOth0AqBKr/eLsLKsXuS4qrtAlB?=
 =?us-ascii?Q?3eZ0xkI2D9t2BVNCI+ZghenonBM4rST6K35mFXZgwBRq9y30LuPh9fPoIm7D?=
 =?us-ascii?Q?eq7HpGNsMC8zdrbPIKfURI5OEgPB5KkAn1poRhEN9+lPYMZKJl2GTqWibHCN?=
 =?us-ascii?Q?z2uZzeLSLT3eabAwb3JJLO0eh2Tmg+z8bLSq+UZFPdqYH97gFTpqx6QJ8hSp?=
 =?us-ascii?Q?OB3qIq4RepbXPWhCt5bfNZBdv6Zwwf83vvIc4UIYWy5ZrmHFa0MzdvyDjL4r?=
 =?us-ascii?Q?c1VeEuDE0SIilrimHyOw8y87zZoRe8K8pBcm3gdSZhxrucVuqKVojQSzORnZ?=
 =?us-ascii?Q?4JBC5TlSARLVNPmqAHN+pfs4YAPZFaZrFMso5WiSsBtVL1GP5OHYdxbWBOQh?=
 =?us-ascii?Q?n2vRIGeIHfjaR0Bc8XMW9zJYxFQ3Pdxz1A12onJ2giAyHHdVzyFsk4y4RRTa?=
 =?us-ascii?Q?Ff+ocPNwlLWa8klbXEj5QHS09IIymD7tWU5f0wKOYoUtEh6zD3lVxzzvvV4K?=
 =?us-ascii?Q?gPGbZdbjngtNgcmHqmNS2M39WceLzzTMszolpzSVw6T7M7K9+QAmwicwCfsp?=
 =?us-ascii?Q?rT7Nt421wvp3vndOOxN0/glIHg36kVl7fpyQzM7d7HOy+PgU7Y7h68IiYZBR?=
 =?us-ascii?Q?YoGh4D8ht7xRdaIXWHBQeNgju4Io5l0XzCE5Qwtvx4hmrfE1bCDMCWcISxS0?=
 =?us-ascii?Q?Anz7NI3tdlYTbYrchbIQNy/gFxn+68QF6H8jG56TUbtdXTGb4sIgB8Iq5kCw?=
 =?us-ascii?Q?xbo1k8tv6vKvZg4kNiq1+Njh36SgbmJVnT8fcUSDlL2HiBjbyJU4JL00yvpH?=
 =?us-ascii?Q?6aAanwbm61qT60wj31vgVuzGgN91sdpmhUOsAusMeHpR6uBAC0EQJuBM7UfP?=
 =?us-ascii?Q?O/pa5T009P9STuy6xizmRuf63Phmq6hnJeYQAhx7d7B7rUNQdHINzcQJZehe?=
 =?us-ascii?Q?kgobXvyFCQ=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23e009b3-8bb9-4e7a-a7da-08da1af2b144
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2022 13:04:48.7320
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: palYSNkbmCopOT2YiEHJuOOLpSVgJ56hU9hcMdiyr9HJKmAa4gATJ10+dIBx0B6Q3xkpgLx2/ZnuxOQEAQBwYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3681
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 05, 2022 at 01:32:13PM -0500, Carlos Bilbao wrote:

...

>  /*
> - * See AMD Error Scope Hierarchy table in a newer BKDG. For example
> - * 49125_15h_Models_30h-3Fh_BKDG.pdf, section "RAS Features"
> + * See AMD PPR(s) section Machine Check Error Handling
>   */

This is now a single-line comment, so the /* */ should be adjusted. This is a
minor issue, so please wait for further review by others before sending
another revision, if needed.

Otherwise, the patch looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks!

-Yazen