Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030942AbXECKri (ORCPT ); Thu, 3 May 2007 06:47:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031141AbXECKri (ORCPT ); Thu, 3 May 2007 06:47:38 -0400 Received: from opal.biophys.uni-duesseldorf.de ([134.99.176.7]:59605 "EHLO opal.biophys.uni-duesseldorf.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030942AbXECKrh (ORCPT ); Thu, 3 May 2007 06:47:37 -0400 Date: Thu, 3 May 2007 12:47:12 +0200 (CEST) From: Michael Schmitz To: Christoph Hellwig cc: Geert Uytterhoeven , Linus Torvalds , Andrew Morton , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Michael Schmitz , Roman Zippel Subject: Re: [patch 04/33] m68k: Atari keyboard and mouse support. In-Reply-To: <20070501205740.GC21080@infradead.org> Message-ID: References: <20070501203234.252205858@mail.of.borg> <20070501203330.172479999@mail.of.borg> <20070501205740.GC21080@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 24 On Tue, 1 May 2007, Christoph Hellwig wrote: > What's the reason for splitting this up? Things would be a quite a bit > simpler if all the code was directly in atakeyb.c. Simple: I assumed that keeping the input driver code with the other input stuff was the Right Thing. I can move everything back to atakeyb.c if that's preferred. > > +/* > > + * linux/atari/atakeyb.c Shall I update that path, then? :-) Honestly - no one had worked on the Atari code for years, and my number one priority was to get it back into functional state. I'll keep your suggestions in mind when merging the low-level and input parts. Michael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/