Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161832AbXECKzI (ORCPT ); Thu, 3 May 2007 06:55:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161841AbXECKzH (ORCPT ); Thu, 3 May 2007 06:55:07 -0400 Received: from opal.biophys.uni-duesseldorf.de ([134.99.176.7]:59850 "EHLO opal.biophys.uni-duesseldorf.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161838AbXECKzG (ORCPT ); Thu, 3 May 2007 06:55:06 -0400 Date: Thu, 3 May 2007 12:54:21 +0200 (CEST) From: Michael Schmitz To: Christoph Hellwig cc: Michael Schmitz , Geert Uytterhoeven , Linus Torvalds , Andrew Morton , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Michael Schmitz , Roman Zippel Subject: Re: [patch 04/33] m68k: Atari keyboard and mouse support. In-Reply-To: <20070503105024.GA21658@infradead.org> Message-ID: References: <20070501203234.252205858@mail.of.borg> <20070501203330.172479999@mail.of.borg> <20070501205740.GC21080@infradead.org> <20070503105024.GA21658@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1066 Lines: 23 > > > What's the reason for splitting this up? Things would be a quite a bit > > > simpler if all the code was directly in atakeyb.c. > > > > Simple: I assumed that keeping the input driver code with the other input > > stuff was the Right Thing. I can move everything back to atakeyb.c if > > that's preferred. > > I think keeping it all under arch/ makes more sense. drivers/input/ > makes a lot of sense where we have keyboard controllers that are used > on various architectures with slightly different glue, or different > controllers for the same busses. IF you have really totally architecture > specific input devices that require intimate arch knowledge it probably > makes more sense to keep them there. The keyboard controller hardware is used nowhere else, so arch/m68k/atari/atakeyb.c it'll be. Michael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/