Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbXECLL1 (ORCPT ); Thu, 3 May 2007 07:11:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753091AbXECLL1 (ORCPT ); Thu, 3 May 2007 07:11:27 -0400 Received: from caramon.arm.linux.org.uk ([217.147.92.249]:3118 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbXECLLX (ORCPT ); Thu, 3 May 2007 07:11:23 -0400 Date: Thu, 3 May 2007 12:11:13 +0100 From: Russell King To: "Robert P. J. Day" Cc: Linux Kernel Mailing List , linux-scsi@vger.kernel.org Subject: Re: dead CONFIG_ variables: drivers/scsi/ Message-ID: <20070503111113.GC12018@flint.arm.linux.org.uk> Mail-Followup-To: "Robert P. J. Day" , Linux Kernel Mailing List , linux-scsi@vger.kernel.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1271 Lines: 27 On Thu, May 03, 2007 at 06:10:28AM -0400, Robert P. J. Day wrote: > > $ ../dead_config.sh drivers/scsi > ========== ACORNSCSI_CONSTANTS ========== > drivers/scsi/arm/acornscsi.c:106:#undef CONFIG_ACORNSCSI_CONSTANTS > drivers/scsi/arm/acornscsi.c:417:#ifdef CONFIG_ACORNSCSI_CONSTANTS > drivers/scsi/arm/acornscsi.c:495:#ifdef CONFIG_ACORNSCSI_CONSTANTS > ========== SCSI_ACORNSCSI_LINK ========== > drivers/scsi/arm/acornscsi.c:70:#undef CONFIG_SCSI_ACORNSCSI_LINK > drivers/scsi/arm/acornscsi.c:169:#ifdef CONFIG_SCSI_ACORNSCSI_LINK > drivers/scsi/arm/acornscsi.c:1675:#ifdef CONFIG_SCSI_ACORNSCSI_LINK > drivers/scsi/arm/acornscsi.c:2849:#ifdef CONFIG_SCSI_ACORNSCSI_LINK > drivers/scsi/arm/acornscsi.c:2880:#ifdef CONFIG_SCSI_ACORNSCSI_LINK False positives. That #undef is preceded by a comment describing the driver-internal configuration for developers rather than users. I guess they shouldn't be preceded by CONFIG_. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/