Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
To:     Lars Melin <larsm17@gmail.com>
Cc:     sven@svenschwermer.de, linux-usb@vger.kernel.org,
        Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
        linux-kernel@vger.kernel.org, oliver@neukum.org
Subject: Re: [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem
Organization: m
References: <20220407074745.74195-1-sven@svenschwermer.de>
        <20220407074745.74195-2-sven@svenschwermer.de>
        <3b8a8497-df41-8bf4-6816-f4419cb7f950@gmail.com>
Date:   Fri, 08 Apr 2022 15:35:13 +0200
In-Reply-To: <3b8a8497-df41-8bf4-6816-f4419cb7f950@gmail.com> (Lars Melin's
        message of "Fri, 8 Apr 2022 08:15:00 +0700")
Message-ID: <87ee27y9ym.fsf@miraculix.mork.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Lars Melin <larsm17@gmail.com> writes:

> Why do you add this modem to the whitelist?

I believe the clue is the

> +	.driver_info =3D (unsigned long)&wwan_info,

to set FLAG_WWAN instead of the default FLAG_ETHER | FLAG_POINTTOPOINT

> The net interface has the correct cdc_ether attributes so the
> cdc_ether driver should bind automagically without any need for the
> modem to be in the whitelist.

Yes, this sort of works against the class driver philosophy.  But we've
already started down that road, so...


Bj=C3=B8rn