Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220408092415.1603661-1-heiko@sntech.de>
In-Reply-To: <20220408092415.1603661-1-heiko@sntech.de>
From:   Anup Patel <anup@brainfault.org>
Date:   Sat, 9 Apr 2022 09:21:11 +0530
Message-ID: <CAAhSdy0ZPH2a9D0jDNhp5OU2oRdvC-wZcu0Zjtcq9ZhMWcrMng@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: KVM: include missing hwcap.h into vcpu_fp
To:     Heiko Stuebner <heiko@sntech.de>
Cc:     Atish Patra <atishp@atishpatra.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        KVM General <kvm@vger.kernel.org>,
        "open list:KERNEL VIRTUAL MACHINE FOR RISC-V (KVM/riscv)" 
        <kvm-riscv@lists.infradead.org>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 8, 2022 at 2:54 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> vcpu_fp uses the riscv_isa_extension mechanism which gets
> defined in hwcap.h but doesn't include that head file.
>
> While it seems to work in most cases, in certain conditions
> this can lead to build failures like
>
> ../arch/riscv/kvm/vcpu_fp.c: In function =E2=80=98kvm_riscv_vcpu_fp_reset=
=E2=80=99:
> ../arch/riscv/kvm/vcpu_fp.c:22:13: error: implicit declaration of functio=
n =E2=80=98riscv_isa_extension_available=E2=80=99 [-Werror=3Dimplicit-funct=
ion-declaration]
>    22 |         if (riscv_isa_extension_available(&isa, f) ||
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../arch/riscv/kvm/vcpu_fp.c:22:49: error: =E2=80=98f=E2=80=99 undeclared =
(first use in this function)
>    22 |         if (riscv_isa_extension_available(&isa, f) ||
>
> Fix this by simply including the necessary header.
>
> Fixes: 0a86512dc113 ("RISC-V: KVM: Factor-out FP virtualization into sepa=
rate sources")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

I have queued this for RC fixes.

Thanks,
Anup

> ---
>  arch/riscv/kvm/vcpu_fp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kvm/vcpu_fp.c b/arch/riscv/kvm/vcpu_fp.c
> index 4449a976e5a6..d4308c512007 100644
> --- a/arch/riscv/kvm/vcpu_fp.c
> +++ b/arch/riscv/kvm/vcpu_fp.c
> @@ -11,6 +11,7 @@
>  #include <linux/err.h>
>  #include <linux/kvm_host.h>
>  #include <linux/uaccess.h>
> +#include <asm/hwcap.h>
>
>  #ifdef CONFIG_FPU
>  void kvm_riscv_vcpu_fp_reset(struct kvm_vcpu *vcpu)
> --
> 2.35.1
>