Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 9 Apr 2022 20:05:06 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        sparclinux@vger.kernel.org
Subject: Re: [PATCH v2] sparc: cacheflush_32.h needs struct page
Message-ID: <YlHK0rHVcppQSG8L@ravnborg.org>
References: <20220409151609.3715-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220409151609.3715-1-rdunlap@infradead.org>
Precedence: bulk

On Sat, Apr 09, 2022 at 08:16:09AM -0700, Randy Dunlap wrote:
> Add a struct page forward declaration to cacheflush_32.h.
> Fixes this build warning:
> 
>   CC      drivers/crypto/xilinx/zynqmp-sha.o
> In file included from ../arch/sparc/include/asm/cacheflush.h:11,
>                  from ../include/linux/cacheflush.h:5,
>                  from ../drivers/crypto/xilinx/zynqmp-sha.c:6:
> ../arch/sparc/include/asm/cacheflush_32.h:38:37: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
>    38 | void sparc_flush_page_to_ram(struct page *page);
> 
> Exposed by commit 0e03b8fd2936
> ("crypto: xilinx - Turn SHA into a tristate and allow COMPILE_TEST")
> but not Fixes: that commit.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: sparclinux@vger.kernel.org
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
> v2: use forward declaration instead of adding <linux/mm.h> (Sam)
> 
>  arch/sparc/include/asm/cacheflush_32.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/arch/sparc/include/asm/cacheflush_32.h
> +++ b/arch/sparc/include/asm/cacheflush_32.h
> @@ -35,6 +35,7 @@
>  #define flush_page_for_dma(addr) \
>  	sparc32_cachetlb_ops->page_for_dma(addr)
>  
> +struct page;
>  void sparc_flush_page_to_ram(struct page *page);
>  
>  #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1