Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp367516pxb; Tue, 12 Apr 2022 03:56:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsvcmyBnSbeQQ6kIhbvg8mpWfDIDEZ+w8KOxemiM9c57Mj8V5px3ChAjmxLDbUb3xkLL8B X-Received: by 2002:a17:907:2d8d:b0:6e8:886e:fd1e with SMTP id gt13-20020a1709072d8d00b006e8886efd1emr10436245ejc.139.1649760976633; Tue, 12 Apr 2022 03:56:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649760976; cv=none; d=google.com; s=arc-20160816; b=ryx06vCPhlXKDu834r3WBr/Y4qudHRHWpVMN9KD9IxoBkzAdPm6/NDNvCAC8K4yyrN riSmCPkQhn7wJz+QkCie6PFmJr/Gr1fYD4fuXzJjrD2eB8nr3TNTNAU2ZKtp1ELZe1Xo YAdT0QCvw3Kg/Q2elo2Xj4eSfRnGBCBafkJkIUeAkAgl9Ynl6VecXs9f6UGhUn4Ixf+d W4fW6IEE3ohvoaf66Btc2RtXM0nZR8FVqICh/O9UXPNHxu12gClsNcfRMHZhFeUxAMPI YliU7b0UeLcmBCBysxx75XSLSe0sbxZ7PcwejefJ3SOK5Ozs7kQLambxGj9yAYkqugsj jL7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QggrkV5pdSde+BU90epsEgQHm/KWdwSuTmMQp+wdpws=; b=Q49Scx6tdRBtdvToD85mLabc/ycgbPmxkVCOaUCaILV7f8vS5UL1vyP/GBYJ9uXK19 7/74vYHHyuyrZAdSU3K9kEPBsdk5bRHgXV8Hn1hDL3Iib0CPPyu9iF3K7rXoRvg7AK5m +WguIZ6IeD6dQSNcqLaIMkueY6moakmZmxMNBh5+sd5cUWNtqYgTs/JaWZUc4fJfdB3/ NmtUjfsxJOM6NVvVA2Amot++ABG/LoMjkyVRRX0M6KfKY/FHUMbyO9PQbV50QXVKN+s1 fwcjgZ3gAvBUtjxx42DJPWwQ66TE2yBFElwvLJlkXwA87wbOvfDpy5+IRr94ZbEV2lDk 1LMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a1709062b8a00b006e7f5ad72d5si8024320ejg.580.2022.04.12.03.55.50; Tue, 12 Apr 2022 03:56:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242849AbiDIRUw (ORCPT + 99 others); Sat, 9 Apr 2022 13:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242829AbiDIRUm (ORCPT ); Sat, 9 Apr 2022 13:20:42 -0400 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 771C6228A86 for ; Sat, 9 Apr 2022 10:18:30 -0700 (PDT) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4KbMJp1HzLz9sTS; Sat, 9 Apr 2022 19:18:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 39dSKG58ncYZ; Sat, 9 Apr 2022 19:18:18 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4KbMJl4lgtz9sT3; Sat, 9 Apr 2022 19:18:15 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8EE408B765; Sat, 9 Apr 2022 19:18:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id iiYIfqptCmas; Sat, 9 Apr 2022 19:18:15 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (unknown [192.168.203.53]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 994AB8B79F; Sat, 9 Apr 2022 19:18:14 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (localhost [127.0.0.1]) by PO20335.IDSI0.si.c-s.fr (8.17.1/8.16.1) with ESMTPS id 239HI7YE833214 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 9 Apr 2022 19:18:07 +0200 Received: (from chleroy@localhost) by PO20335.IDSI0.si.c-s.fr (8.17.1/8.17.1/Submit) id 239HI7XU833213; Sat, 9 Apr 2022 19:18:07 +0200 X-Authentication-Warning: PO20335.IDSI0.si.c-s.fr: chleroy set sender to christophe.leroy@csgroup.eu using -f From: Christophe Leroy To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , akpm@linux-foundation.org Cc: Christophe Leroy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, Nicholas Piggin Subject: [PATCH v10 05/13] powerpc/mm: Move vma_mmu_pagesize() Date: Sat, 9 Apr 2022 19:17:29 +0200 Message-Id: <1302e000d529c93d07208f1fae90f938e7a551b4.1649523076.git.christophe.leroy@csgroup.eu> X-Mailer: git-send-email 2.35.1 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1649524639; l=1793; s=20211009; h=from:subject:message-id; bh=bx8qaeX914dm/qgyDYd+w6J7NWMH8VOi7HP/6ov9wh8=; b=bbfm6Q4FTG4t1UJFIbhOg831/onZhxL2dVR5Ph6r2MHVentUFeGjusgBMmwJkS+D63kA7JWHfX2y Mx+kYC+3CZyRqGTz6+4W2OhUqqkyBvjLFKqLZ1d+19mNRC34HGmC X-Developer-Key: i=christophe.leroy@csgroup.eu; a=ed25519; pk=HIzTzUj91asvincQGOFx6+ZF5AoUuP9GdOtQChs7Mm0= Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vma_mmu_pagesize() is only required for slices, otherwise there is a generic weak version doing the exact same thing. Move it to slice.c Signed-off-by: Christophe Leroy Reviewed-by: Nicholas Piggin --- arch/powerpc/mm/hugetlbpage.c | 11 ----------- arch/powerpc/mm/slice.c | 9 +++++++++ 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index b642a5a8668f..7b89f0799d82 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c @@ -565,17 +565,6 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, } #endif -unsigned long vma_mmu_pagesize(struct vm_area_struct *vma) -{ - /* With radix we don't use slice, so derive it from vma*/ - if (IS_ENABLED(CONFIG_PPC_MM_SLICES) && !radix_enabled()) { - unsigned int psize = get_slice_psize(vma->vm_mm, vma->vm_start); - - return 1UL << mmu_psize_to_shift(psize); - } - return vma_kernel_pagesize(vma); -} - bool __init arch_hugetlb_valid_size(unsigned long size) { int shift = __ffs(size); diff --git a/arch/powerpc/mm/slice.c b/arch/powerpc/mm/slice.c index f42711f865f3..8a3ac062b71e 100644 --- a/arch/powerpc/mm/slice.c +++ b/arch/powerpc/mm/slice.c @@ -759,4 +759,13 @@ int slice_is_hugepage_only_range(struct mm_struct *mm, unsigned long addr, return !slice_check_range_fits(mm, maskp, addr, len); } + +unsigned long vma_mmu_pagesize(struct vm_area_struct *vma) +{ + /* With radix we don't use slice, so derive it from vma*/ + if (radix_enabled()) + return vma_kernel_pagesize(vma); + + return 1UL << mmu_psize_to_shift(get_slice_psize(vma->vm_mm, vma->vm_start)); +} #endif -- 2.35.1