Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c8d3ed7196d09f5f6a61d605a94613f792ab501b.camel@pengutronix.de>
Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod
 interface
From:   Lucas Stach <l.stach@pengutronix.de>
To:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        =?ISO-8859-1?Q?Ma=EDra?= Canal <maira.canal@usp.br>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc:     hongxing.zhu@nxp.com, robh@kernel.org, bhelgaas@google.com,
        helgaas@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, linux-imx@nxp.com,
        linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 11 Apr 2022 18:03:51 +0200
In-Reply-To: <20220411115926.GA20890@francesco-nb.int.toradex.com>
References: <YYCOTx68LXu1Tn1i@fedora> <YlBFa46v5NtWxGLt@lpieralisi>
         <YlBKyBtbxMpvauLv@fedora>
         <20220411115926.GA20890@francesco-nb.int.toradex.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Maíra, hi Lorenzo,

Am Montag, dem 11.04.2022 um 13:59 +0200 schrieb Francesco Dolcini:
> On Fri, Apr 08, 2022 at 11:46:32AM -0300, Maíra Canal wrote:
> > On Fri, Apr 08, 2022 at 03:23:39PM +0100, Lorenzo Pieralisi wrote:
> > > On Mon, Nov 01, 2021 at 10:03:11PM -0300, Maíra Canal wrote:
> > > > Considering the current transition of the GPIO subsystem, remove all
> > > > dependencies of the legacy GPIO interface (linux/gpio.h and linux
> > > > /of_gpio.h) and replace it with the descriptor-based GPIO approach.
> > > > 
> > > > Signed-off-by: Maíra Canal <maira.canal@usp.br>
> > > > ---
> > > > V1 -> V2: Rewrite commit log and subject line to match PCI subsystem standard
> > > > V2 -> v3: Change gpiod_set_value_cansleep for gpiod_set_raw_value_cansleep
> > > > ---
> > > >  drivers/pci/controller/dwc/pci-imx6.c | 30 +++++++++------------------
> > > >  1 file changed, 10 insertions(+), 20 deletions(-)
> > > 
> > > Maira, Lucas,
> > > 
> > > what's this patch status ? Please let me know.

The patch looks fine to me now, however...

> > 
> > Thank you for the feedback. Since I sent v3, I didn't get any feedback from the community.
> > 
> > If you have any feedback, I would gladly work on it.
> 
> Just for you to know that it will likely conflict with
> 'PCI: imx6: Fix PERST# start-up sequence' [0] that is also still waiting
> for some additional feedback.

... they do conflict and I guess the functional fix for the reset
sequence should have priority over this cleanup. Maíra, may I ask you
to respin your patch as soon as Francescos fix is in? I promise to not
let it fall through the cracks again.

Regards,
Lucas