Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Apr 2022 12:00:51 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HSI: omap_ssi: Fix refcount leak in ssi_probe
Message-ID: <20220412100051.g2mx734l3ogz4tcw@mercury.elektranox.org>
References: <20220404085234.11435-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ixa6kldo263d7ftb"
Content-Disposition: inline
In-Reply-To: <20220404085234.11435-1-linmq006@gmail.com>
Precedence: bulk


--ixa6kldo263d7ftb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Apr 04, 2022 at 08:52:32AM +0000, Miaoqian Lin wrote:
> When returning or breaking early from a
> for_each_available_child_of_node() loop, we need to explicitly call
> of_node_put() on the child node to possibly release the node.
>=20
> Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/hsi/controllers/omap_ssi_core.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/contro=
llers/omap_ssi_core.c
> index 44a3f5660c10..eb9820158318 100644
> --- a/drivers/hsi/controllers/omap_ssi_core.c
> +++ b/drivers/hsi/controllers/omap_ssi_core.c
> @@ -524,6 +524,7 @@ static int ssi_probe(struct platform_device *pd)
>  		if (!childpdev) {
>  			err =3D -ENODEV;
>  			dev_err(&pd->dev, "failed to create ssi controller port\n");
> +			of_node_put(child);
>  			goto out3;
>  		}
>  	}
> --=20
> 2.17.1
>=20

--ixa6kldo263d7ftb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmJVTdIACgkQ2O7X88g7
+ppUIQ//T7c/a0qTM32ohIR1Ub6EjXz7gD34N39VYe8WSU66275ZD25TQ/fPQSqO
zSQ+ih1eV2oCHsr33EUqS5SkIsAYrG6J0IXM/Qg8u9yW6MzOenwVQAbsMIIsf9l2
ezMDYmJNJASyZHcOMsBp0YYfNmcUVlTFSAcZzsUE0ti4rfVr4vYI+Qg+y0Fj6bDd
Zt43pTPeIe29KLHDxmIcvgmxh3w4YOlQ1NcJkbw3KdK7ATZdlXS9fHCwA+e/s5XN
vIj5HezNbtDihY6AOhiFmeSd4KB1dD6IvMzGDDSoGyNDKeWK2H5noXD6A74m4ahg
3nu+VZ9YLJ+YL8vSijvdO+TNZf1nDfRWHWM3PVdpxrJpgNmIIt7Z4T5zUHW4vjGa
iUIpeOY6nQaX3rgdm5/Ghe1NVE0Mxg7OakAQKt+EPmBKb8VaIG4H1FmGtlHAiJng
jfRaF5wbtKqpCr53n/bakV2Jb8A8qXxnQHUG55al+oQQgXCx282551mHTbxVTPeA
CU5yajV9nEx/6WMPfHExwWR57XOv73RbnC0xzs4Tur/DweApHlH0rqi0iEmDfLgx
6lmnX3qXXuvgyt0/WlipDScetMIGrdeST/X5z5rk29Br/3jXyUVZ2ed7JmzMDuNM
f5ZqVk42EqzAEotHVEjfujgrtJarZ5I4Vb60F5WVfHh5JkUft3E=
=jxKn
-----END PGP SIGNATURE-----

--ixa6kldo263d7ftb--