Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: [PATCH v2 4/4] tools/perf: Fix perf bench numa testcase to check
 if CPU used to bind task is online
From:   Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <YlGkVPyn2/tpUZl2@kernel.org>
Date:   Mon, 11 Apr 2022 19:24:18 +0530
Cc:     Jiri Olsa <jolsa@kernel.org>, disgoel@linux.vnet.ibm.com,
        Michael Ellerman <mpe@ellerman.id.au>,
        linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        maddy@linux.vnet.ibm.com,
        Nageswara Sastry <rnsastry@linux.ibm.com>,
        kajoljain <kjain@linux.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Ian Rogers <irogers@google.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <03FDBB52-5803-4254-81E5-875008E203A6@linux.vnet.ibm.com>
References: <20220406175113.87881-1-atrajeev@linux.vnet.ibm.com>
 <20220406175113.87881-5-atrajeev@linux.vnet.ibm.com>
 <YlGkVPyn2/tpUZl2@kernel.org>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Precedence: bulk


> On 09-Apr-2022, at 8:50 PM, Arnaldo Carvalho de Melo <acme@kernel.org> =
wrote:
>=20
> Em Wed, Apr 06, 2022 at 11:21:13PM +0530, Athira Rajeev escreveu:
>> Perf numa bench test fails with error:
>>=20
>> Testcase:
>> ./perf bench numa mem -p 2 -t 1 -P 1024 -C 0,8 -M 1,0 -s 20 -zZq
>> --thp  1 --no-data_rand_walk
>>=20
>> Failure snippet:
>> <<>>
>> Running 'numa/mem' benchmark:
>>=20
>> # Running main, "perf bench numa numa-mem -p 2 -t 1 -P 1024 -C 0,8
>> -M 1,0 -s 20 -zZq --thp 1 --no-data_rand_walk"
>>=20
>> perf: bench/numa.c:333: bind_to_cpumask: Assertion `!(ret)' failed.
>> <<>>
>>=20
>> The Testcases uses CPU=E2=80=99s 0 and 8. In function =
"parse_setup_cpu_list",
>> There is check to see if cpu number is greater than max cpu=E2=80=99s =
possible
>> in the system ie via "if (bind_cpu_0 >=3D g->p.nr_cpus ||
>> bind_cpu_1 >=3D g->p.nr_cpus) {". But it could happen that system has
>> say 48 CPU=E2=80=99s, but only number of online CPU=E2=80=99s is 0-7. =
Other CPU=E2=80=99s
>> are offlined. Since "g->p.nr_cpus" is 48, so function will go ahead
>> and set bit for CPU 8 also in cpumask ( td->bind_cpumask).
>>=20
>> bind_to_cpumask function is called to set affinity using
>> sched_setaffinity and the cpumask. Since the CPU8 is not present,
>> set affinity will fail here with EINVAL. Fix this issue by adding a
>> check to make sure that, CPU=E2=80=99s provided in the input argument =
values
>> are online before proceeding further and skip the test. For this,
>> include new helper function "is_cpu_online" in
>> "tools/perf/util/header.c".
>>=20
>> Since "BIT(x)" definition will get included from header.h, remove
>> that from bench/numa.c
>>=20
>> Tested-by: Disha Goel <disgoel@linux.vnet.ibm.com>
>> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
>> Reported-by: Disha Goel <disgoel@linux.vnet.ibm.com>
>> ---
>> tools/perf/bench/numa.c  |  8 ++++++--
>> tools/perf/util/header.c | 43 =
++++++++++++++++++++++++++++++++++++++++
>> tools/perf/util/header.h |  1 +
>> 3 files changed, 50 insertions(+), 2 deletions(-)
>>=20
>> diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
>> index 29e41e32bd88..7992d79b3e41 100644
>> --- a/tools/perf/bench/numa.c
>> +++ b/tools/perf/bench/numa.c
>> @@ -34,6 +34,7 @@
>> #include <linux/numa.h>
>> #include <linux/zalloc.h>
>>=20
>> +#include "../util/header.h"
>> #include <numa.h>
>> #include <numaif.h>
>>=20
>> @@ -616,6 +617,11 @@ static int parse_setup_cpu_list(void)
>> 			return -1;
>> 		}
>>=20
>> +		if (is_cpu_online(bind_cpu_0) !=3D 1 || =
is_cpu_online(bind_cpu_1) !=3D 1) {
>> +			printf("\nTest not applicable, bind_cpu_0 or =
bind_cpu_1 is offline\n");
>> +			return -1;
>> +		}
>> +
>> 		BUG_ON(bind_cpu_0 < 0 || bind_cpu_1 < 0);
>> 		BUG_ON(bind_cpu_0 > bind_cpu_1);
>>=20
>> @@ -786,8 +792,6 @@ static int parse_nodes_opt(const struct option =
*opt __maybe_unused,
>> 	return parse_node_list(arg);
>> }
>>=20
>> -#define BIT(x) (1ul << x)
>> -
>> static inline uint32_t lfsr_32(uint32_t lfsr)
>> {
>> 	const uint32_t taps =3D BIT(1) | BIT(5) | BIT(6) | BIT(31);
>> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
>> index 6da12e522edc..3f5fcf5d4b3f 100644
>> --- a/tools/perf/util/header.c
>> +++ b/tools/perf/util/header.c
>> @@ -983,6 +983,49 @@ static int write_dir_format(struct feat_fd *ff,
>> 	return do_write(ff, &data->dir.version, =
sizeof(data->dir.version));
>> }
>>=20
>> +#define SYSFS "/sys/devices/system/cpu/"
>=20
> Please use
>=20
> int sysfs__read_str(const char *entry, char **buf, size_t *sizep)

Hi Arnaldo,

Sure, I will send a V3 for this separately which uses =
=E2=80=9Csysfs__read_str=E2=80=9D

Thanks for the review
Athira
>=20
> See how to use it in the smt_on() function at tools/perf/util/smt.c, =
for
> example.
>=20
> Now looking at the first patches in the series.
>=20
> - Arnaldo
>=20
>> +/*
>> + * Check whether a CPU is online
>> + *
>> + * Returns:
>> + *     1 -> if CPU is online
>> + *     0 -> if CPU is offline
>> + *    -1 -> error case
>> + */
>> +int is_cpu_online(unsigned int cpu)
>> +{
>> +	char sysfs_cpu[255];
>> +	char buf[255];
>> +	struct stat statbuf;
>> +	size_t len;
>> +	int fd;
>> +
>> +	snprintf(sysfs_cpu, sizeof(sysfs_cpu), SYSFS "cpu%u", cpu);
>> +
>> +	if (stat(sysfs_cpu, &statbuf) !=3D 0)
>> +		return 0;
>> +
>> +	/*
>> +	 * Check if /sys/devices/system/cpu/cpux/online file
>> +	 * exists. In kernels without CONFIG_HOTPLUG_CPU, this
>> +	 * file won't exist.
>> +	 */
>> +	snprintf(sysfs_cpu, sizeof(sysfs_cpu), SYSFS "cpu%u/online", =
cpu);
>> +	if (stat(sysfs_cpu, &statbuf) !=3D 0)
>> +		return 1;
>> +
>> +	fd =3D open(sysfs_cpu, O_RDONLY);
>> +	if (fd =3D=3D -1)
>> +		return -1;
>> +
>> +	len =3D read(fd, buf, sizeof(buf) - 1);
>> +	buf[len] =3D '\0';
>> +	close(fd);
>> +
>> +	return strtoul(buf, NULL, 16);
>> +}
>> +
>> #ifdef HAVE_LIBBPF_SUPPORT
>> static int write_bpf_prog_info(struct feat_fd *ff,
>> 			       struct evlist *evlist __maybe_unused)
>> diff --git a/tools/perf/util/header.h b/tools/perf/util/header.h
>> index c9e3265832d9..0eb4bc29a5a4 100644
>> --- a/tools/perf/util/header.h
>> +++ b/tools/perf/util/header.h
>> @@ -158,6 +158,7 @@ int do_write(struct feat_fd *fd, const void *buf, =
size_t size);
>> int write_padded(struct feat_fd *fd, const void *bf,
>> 		 size_t count, size_t count_aligned);
>>=20
>> +int is_cpu_online(unsigned int cpu);
>> /*
>>  * arch specific callback
>>  */
>> --=20
>> 2.35.1
>=20
> --=20
>=20
> - Arnaldo