Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Miaoqian Lin <linmq006@gmail.com>,
        Song Qiang <songqiang1304521@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Ivan Drobyshevskyi <drobyshevskyi@gmail.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: proximity: Fix return value check of
 wait_for_completion_timeout
Thread-Topic: [PATCH] iio: proximity: Fix return value check of
 wait_for_completion_timeout
Thread-Index: AQHYThl99NRYKGRf3UqRiCXMHbklwqzrzqNQ
Date:   Tue, 12 Apr 2022 06:21:15 +0000
Message-ID: <PH0PR03MB67863270EC86D06606F1E44E99ED9@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220412030022.20249-1-linmq006@gmail.com>
In-Reply-To: <20220412030022.20249-1-linmq006@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?BY/r4IvchMce9E2lNE4Aq31ChcGv4vKtCokbyohGu+9vJOzLhvARskQhEP?=
 =?iso-8859-1?Q?gcmUuajFtGqk/yHOd68WmtlZm8T03vNvHGn0VdCFFbWQhVyPDLgfkU0ME7?=
 =?iso-8859-1?Q?NorYLAu1YpJwgIHxGvwjNGVdbXLD+qwCg4eBSIvIGPX2mwO5SS/IfOD7LA?=
 =?iso-8859-1?Q?SbFrNc72+jNvfi+LOR5Jz8BpXvo9acO1NfToB2HOEPFE8heu4QEw9ZLZ72?=
 =?iso-8859-1?Q?gRoeeBIG5K3xmeGr9Ei6uALV/+KtS3TawjIIUsfMS76dEQD7Eco5gHqYAz?=
 =?iso-8859-1?Q?0ZUxeqlMxPvNIF74CQvWPDmA52kB04+kIw6UR3NJP7Mmm4csIDcgia15GB?=
 =?iso-8859-1?Q?QMxc2xIuep/jK2gop22Z20nj7tAsxU7htU0lLTJdYWvJQfofwQzDQugoH8?=
 =?iso-8859-1?Q?HeEkMW4CFcbtNBPlk5LJfsPlXzV6JEVeBrV2dBQcb3omzg6MaN+F0PY2iA?=
 =?iso-8859-1?Q?Y7bVf1S5okEMBZzW1A1XXJbrf17amsSFnYW7yE9AVAUsAWIlO/SFkDPtNg?=
 =?iso-8859-1?Q?rwp3eikGUE9QuxhG34k3rUhSZFLFdHjX1cHQPwaHJvG3OOqV3JIxcqO+ZH?=
 =?iso-8859-1?Q?hkMvng4Edvz4h4lyADO9y+kg1SnuFb5XzQZcSUKfxhOTLH0QTj8Vh9Wwwf?=
 =?iso-8859-1?Q?M8urSCLIpbKiE+3F4pMkNuxKKwdJHwQu576eXDHFrlhy0nCGGH/9bA/8yd?=
 =?iso-8859-1?Q?JjK83PZxzr1IYwj+EbcAfnzrxd7bDqSODin5YNbbdWnAHdj6RD0V43OIFf?=
 =?iso-8859-1?Q?hN8CVfPbGSJVvRozlc3/MQ+KD4q8OJinIDI0b98rLVwotSND93zG2/fZsp?=
 =?iso-8859-1?Q?tZQn2PzW4NxKMVCDRQS8Kb/cGIef7xQ1epuXn+9F/0tPQuOq3AgSCSD35C?=
 =?iso-8859-1?Q?D+60NfUXsB3iahe08R3MPF8LHNyP6ivigvjBFz2VNByat5mz2ogyug7v8y?=
 =?iso-8859-1?Q?LRqK3DOh5YZOsO2RTHoazTVjFhOY75OMV/JAs8EAYV4uT0lHKRWjGMPVet?=
 =?iso-8859-1?Q?y9nM2isM5UsEbxf/qR8tG9mcbfFKi/S32BWhGmmt9T/1+jqS9KRIrA47gi?=
 =?iso-8859-1?Q?sCccE3i1d42221+W3hC6kdbF4waRJ0tVe8THA6OJyI5PXcd6RRf2cmMA4S?=
 =?iso-8859-1?Q?b9sugN+9Rt2jrTQ074iwx3hyNrjT+GiYeBJvB7T1+f1FUsaU2pzolVvU3O?=
 =?iso-8859-1?Q?UsOqmEYPI0E+LNl3qBTAOGOvOnqT/kFj3oRe5olPMyi5H0tBQyoSDILkBx?=
 =?iso-8859-1?Q?YKdhZs2c9C4NjeZQ2NpP8ijMbBiYPWd/I8KiJ22P5WAzIwten9yevUQf5a?=
 =?iso-8859-1?Q?nSnAWVKUj3BaPNKavkS4YJYimdcT5qXi9hkuOqvQQK64mXqnl/czEKUbb0?=
 =?iso-8859-1?Q?AitS4qGWbri1GjyH6uJCXYX57Xr2z4AFYpJuH3D7WcQIWvEdqH2ZaH4LRd?=
 =?iso-8859-1?Q?iDDRBKSQyiwuIuAnQQUUar23Btow5VwSchNb6tU4FVd/USkJ1sGrX9wvXE?=
 =?iso-8859-1?Q?9MWKVUPMAOvQwURhpxLML41E83icZovyDM69KY/O3R7ZE6oXa9CBmCR2su?=
 =?iso-8859-1?Q?6sUNUtMHDCX8561NWY6niCrQZCzaLu5lbvIURGvhu3hr3Lr6PyLVKISyvs?=
 =?iso-8859-1?Q?9+rZdWPBHkvifWiW22MLWPf3pMMwtJxSsZ6Ni75WqkdjCRpoLEFdPzV5SW?=
 =?iso-8859-1?Q?HAgI8qoblfiuZ448/R2EipvIq6opCxugXfnCb9gusDSJa0zgwGpF+OwcrL?=
 =?iso-8859-1?Q?4xJR8zBrJdEFGJgQz+0fdGyvSxuK6oj5KwkmtMT2Mi8wWbKW+3vajAyv/Z?=
 =?iso-8859-1?Q?iQg3D9/f9lv+Fz/Z5DhKIO9dUjw/AnlnwCRMMKnT2bE0DmNilb9C0mDvg/?=
 =?iso-8859-1?Q?qU?=
x-ms-exchange-antispam-messagedata-1: D5Ynl9oHE97u8A==
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6786.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c9c3b24-aa1d-42f3-dfd6-08da1c4ca601
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 06:21:15.3642
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uLnBnrc2h8GEKZgETJ1quZ1BoLkkcqAGd95DW6exfUSdFBRJi5wikB/vqJDTi6fbpYPN+i0POWb+DQRewJh4Og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6191
X-Proofpoint-GUID: 7xyUSTFM_rZjC9qdZq4IjJMPWE1HpVMr
X-Proofpoint-ORIG-GUID: 7xyUSTFM_rZjC9qdZq4IjJMPWE1HpVMr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-04-12_02,2022-04-11_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999
 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501
 clxscore=1011 adultscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204120029
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Miaoqian Lin <linmq006@gmail.com>
> Sent: Tuesday, April 12, 2022 5:00 AM
> To: Song Qiang <songqiang1304521@gmail.com>; Jonathan Cameron
> <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; Ivan
> Drobyshevskyi <drobyshevskyi@gmail.com>; linux-
> iio@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: linmq006@gmail.com
> Subject: [PATCH] iio: proximity: Fix return value check of
> wait_for_completion_timeout
>=20
> [External]
>=20
> wait_for_completion_timeout() returns unsigned long not int.
> It returns 0 if timed out, and positive if completed.
> The check for <=3D 0 is ambiguous and should be =3D=3D 0 here
> indicating timeout which is the only error case.
>=20
> Fixes: 3cef2e31b54b ("iio: proximity: vl53l0x: Add IRQ support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---

Reviewed-by: Nuno S=E1 <nuno.sa@analog.com>

>  drivers/iio/proximity/vl53l0x-i2c.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/iio/proximity/vl53l0x-i2c.c
> b/drivers/iio/proximity/vl53l0x-i2c.c
> index 661a79ea200d..a284b20529fb 100644
> --- a/drivers/iio/proximity/vl53l0x-i2c.c
> +++ b/drivers/iio/proximity/vl53l0x-i2c.c
> @@ -104,6 +104,7 @@ static int vl53l0x_read_proximity(struct
> vl53l0x_data *data,
>  	u16 tries =3D 20;
>  	u8 buffer[12];
>  	int ret;
> +	unsigned long time_left;
>=20
>  	ret =3D i2c_smbus_write_byte_data(client,
> VL_REG_SYSRANGE_START, 1);
>  	if (ret < 0)
> @@ -112,10 +113,8 @@ static int vl53l0x_read_proximity(struct
> vl53l0x_data *data,
>  	if (data->client->irq) {
>  		reinit_completion(&data->completion);
>=20
> -		ret =3D wait_for_completion_timeout(&data-
> >completion, HZ/10);
> -		if (ret < 0)
> -			return ret;
> -		else if (ret =3D=3D 0)
> +		time_left =3D wait_for_completion_timeout(&data-
> >completion, HZ/10);
> +		if (time_left =3D=3D 0)
>  			return -ETIMEDOUT;
>=20
>  		vl53l0x_clear_irq(data);
> --
> 2.17.1