Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        netdev@vger.kernel.org (open list:NETWORKING [IPv4/IPv6]),
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] ipv6: exthdrs: use swap() instead of open coding it
Date:   Tue, 12 Apr 2022 11:20:58 +0800
Message-Id: <20220412032058.14136-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pvp7Dq3KOjIz3W18qBFQLEqwxU3xj9SNq7c7+qbN4qJEDgL2RfvXw9bceu8c?=
 =?us-ascii?Q?wnwyLgRVxCTjgTS77fSTX+gaCQHQfk74Qj/4EHnjoLG1r/jVJ2C8y6X6c+T+?=
 =?us-ascii?Q?UpMl10980i2TP/57bUuXMn60GBfYznrp8/UcZlTBmEoLqve7bbTbFPhLVUrZ?=
 =?us-ascii?Q?8Ksq9ISRz5+PA7UMbaq9ME0jL7FQIu7oxc4NkXDhF+IhDVj01xGI5Y7D1pib?=
 =?us-ascii?Q?AlnvFxIqup8pMuep/0QGcqI/A0DmXfZkOCKTIet9051XJJdbvFRk6ArsD3w5?=
 =?us-ascii?Q?kL3v9r/DnEycKkaXXzDoRTDuukMghvcYC41L2MYxkvDuqKwjSs03ZiDAPtTY?=
 =?us-ascii?Q?tHcC3imwwzyeQziPwmoOnTf8sE/jrerPNxi+jaixcwpUu7uiZetqm2d5atlQ?=
 =?us-ascii?Q?hc2BQRPQpQWSuGLepc+pd3GA0hESfLB7Y0EDWp4oP6dYiALBJS7cQpdfloY+?=
 =?us-ascii?Q?gjO8mRKXQvPteBSbHpsz5yRcyOefgr7kNAtUd/JffUzwoA3lChPwApROSDJS?=
 =?us-ascii?Q?ErNLzdJyGY1x2+Vc1UuAbAnLXbJwIlmAf2ffdoWKz4kgfAoEVkxMEvma730e?=
 =?us-ascii?Q?Xj7aHuOgWmDadW+bdGFVDvjPhtzGavEdWk79DZRrLISMj6UheXlpiGAVFOu9?=
 =?us-ascii?Q?lbouFFA65VRaOmCcHt9y/yFuyxZowU01rRp5m6GzR1GEs4Feq3QagbeStyic?=
 =?us-ascii?Q?hXCnrcybxf/peHPZExeByCxrnZq9y0eobj1Jf36Cqv5eTApAmMnjzfwFwKJr?=
 =?us-ascii?Q?TqYtODLmILglqPKrG52wcBPRGlaQs3296oXKmGAGhIRQmHUjWS4bV6tG1lmB?=
 =?us-ascii?Q?j3124mJq4Jz28i0UlK2oXyJW1dmoDmWGGeKxE6kQw23HW6+12vBDRWgqLcCH?=
 =?us-ascii?Q?fLf2SsLkzQ7VWvRKizSqkA1XmQ0fvTd1GMO6oERfnqG0lvroU5oxV5Uti9hv?=
 =?us-ascii?Q?laI9Vgss7syL8NJjQAcXf4i3I2tlCiNkt2tSgsRIKGggzP+rzzYAIUpGlw8b?=
 =?us-ascii?Q?bWkKSw2W4BGi+pK40yntIYfGCQC6BUtpGoQSpmEZyLFhUsQRk1W0AGMsghaH?=
 =?us-ascii?Q?qAz5LS9gwYM+LJFyCy/b9oU+hlHERAPfrMkXaIWy7LknPAbnWZqgaHjDv8Bv?=
 =?us-ascii?Q?8tmjsOMBP+vNgz0cjnSzs17dXogg+WVt34dXMEUS5WqV5EkiGMwpxQp7iBlh?=
 =?us-ascii?Q?v4kR/P+HVLRmBLEfBezD8uWxyilVHLUD4EkYEZeSYD9xiteWBMbfGv20wh46?=
 =?us-ascii?Q?ZRIVMZidhp0ZdQ/aHpWj0rxzXTNSdYae4R0GvSn8070firpWJZlljLmsGJRO?=
 =?us-ascii?Q?cwOO6NUHTFKJSPm9CMde2x1w+4u04Fxab7rJhQF1NOwsZC/E200g/AvbKjDf?=
 =?us-ascii?Q?b/MV3aEoZaMh6HT6eHdU2HzhnCTtoou4dMlXM0/IylKk0KVGKnAEDA9n9sQ0?=
 =?us-ascii?Q?YaOi8/Sa3htMkdXl9S7S7X3eVUWGqacqp+vscAShQ4kfQqrlWT76hHtgwWkk?=
 =?us-ascii?Q?R8uUTIcDKQtEtITBu1wFLjbo0HC7o+mKUM37ejtg8R18988FGHWuxpkn3OP2?=
 =?us-ascii?Q?IyvdxnKGdhHxFRw6lNgTXZjW1hH0zJjMNMmUv1ejWHAO7bK3DBuU7F3k1MBw?=
 =?us-ascii?Q?MwDU1wsZU5B5jr1EFzi2g/WWiSvrhVyrbiyOdo50JnKumIkt6j/ySGm9Xv+g?=
 =?us-ascii?Q?LuxqzfWSKPH5d6ISV+ZCQWhqgplCovtmUYWPKccD6ylEo205q811LqzgbSgd?=
 =?us-ascii?Q?4yHcmuglCg=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc0f0dfa-128a-46c9-00ab-08da1c337cb6
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 03:21:08.9121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: orEaXIQfYDFJNscZpMakdQ9zC16zDph+59/rJOq67vVruvrLL1ZD2kZHbKPq/082L0DPrU9GwZ7q8iXWrROfaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4637
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Address the following coccicheck warning:
net/ipv6/exthdrs.c:620:44-45: WARNING opportunity for swap()

by using swap() for the swapping of variable values and drop
the tmp (`addr`) variable that is not needed any more.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 net/ipv6/exthdrs.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index 658d5eabaf7e..a2094aa1cb32 100644
--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -487,7 +487,6 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb)
 	struct net *net = dev_net(skb->dev);
 	struct inet6_dev *idev;
 	struct ipv6hdr *oldhdr;
-	struct in6_addr addr;
 	unsigned char *buf;
 	int accept_rpl_seg;
 	int i, err;
@@ -616,9 +615,7 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb)
 		return -1;
 	}
 
-	addr = ipv6_hdr(skb)->daddr;
-	ipv6_hdr(skb)->daddr = ohdr->rpl_segaddr[i];
-	ohdr->rpl_segaddr[i] = addr;
+	swap(ipv6_hdr(skb)->daddr, ohdr->rpl_segaddr[i]);
 
 	ipv6_rpl_srh_compress(chdr, ohdr, &ipv6_hdr(skb)->daddr, n);
 
-- 
2.20.1