Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: L3lZoWV6DwyR85+9xWyYLfJjhp6OZuHimoBhxIMZkUAX9s1qhOyM218zogZlyGb5R5IBfi0gzY
 IkfO2wmN83Pk9E2pPtt6l2nn1wE8Vyfb7WR9zGc7E3qcNEJx8wdm5XfADyqXh7stwHQMgNlRVu
 rViskp8E1t4ViW7N68rDc4UhKyhtHNUiM3l2rUD5OlACySMBsLk+9QB8MIN3NhbAGZIpWYOo26
 ZFFNu7dWuUsqZpPFLkn7ZrZGBaIp8ek0Jr/D0nalRfHKM3CgJIW6Hq2/1LC1laBEwp6iWdYfI9
 la9GSvFq9LKFa8Uk0/Mkuncs
IronPort-SDR: jA/8yFTQp1tDbGLEO6owpNSHUvySvi459nqz5VLNt8RjIR7W3o1p6Y9o4AOeyKgpfAr4zw6ZSX
 aOruoISIOZQsJ4sqks0e3uyYBwbXBcEmdr5Zv1rZankSZkmIV1QUMlfg4n+UYcHOx/dWV/rzha
 MD5J/aQye7iBY6D0KJ5Xm9MCv1cvjTAgiwt3NMqjwp7QOrrNzcKXSeSxU8Ps4z3uwcZhaVHqEI
 aGV43mRb+8QGyH290l3eGcVzBva9q3SMzirYxchX84ZOgZDIeZR+SBf3cCgXfDi5nxnaN4EoEZ
 sig=
WDCIronportException: Internal
Message-ID: <05433153-0424-ab66-1573-993d0490c5bc@opensource.wdc.com>
Date:   Mon, 11 Apr 2022 08:53:29 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [BUG] ata: pata_marvell: Warning when probing the module
Content-Language: en-US
To:     Zheyu Ma <zheyuma97@gmail.com>, Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     linux-ide@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAMhUBjkVME8D5KsHvT=uddBsW_Bh6wr7qeXS=UpQD4LgPmHffQ@mail.gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <CAMhUBjkVME8D5KsHvT=uddBsW_Bh6wr7qeXS=UpQD4LgPmHffQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/10/22 15:30, Zheyu Ma wrote:
> Hello,
> 
> I found a bug in the pata_marvell module.
> When probing the driver, it seems to trigger the error path and
> executes the function marvell_cable_detect(), but the
> 'ap->ioaddr.bmdma_addr' is not initialized, which causes a warning.

I do not have this hardware so I cannot debug this. Please debug it and
send a patch. bmdma_addr is normally set in ata_pci_bmdma_init(), but some
drivers set it manually in their probe functions. No idea about the
marvell driver, I have not checked it.

> 
> The following log can reveal it:
> 
> [    3.453943] Bad IO access at port 0x1 (return inb(port))
> [    3.454430] WARNING: CPU: 7 PID: 291 at lib/iomap.c:44 ioread8+0x4a/0x60
> [    3.457962] RIP: 0010:ioread8+0x4a/0x60
> [    3.466362] Call Trace:
> [    3.466572]  <TASK>
> [    3.466756]  marvell_cable_detect+0xad/0xf0 [pata_marvell]
> [    3.467699]  ata_eh_recover+0x3520/0x6cc0
> [    3.473262]  ata_do_eh+0x49/0x3c0
> [    3.473906]  ata_scsi_port_error_handler+0xd96/0x1d00
> [    3.474355]  ata_scsi_error+0x243/0x290
> [    3.475428]  scsi_error_handler+0x2ff/0xea0
> [    3.477244]  kthread+0x262/0x2e0


-- 
Damien Le Moal
Western Digital Research