Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220409034849.3717231-1-zheyuma97@gmail.com> <20220409034849.3717231-2-zheyuma97@gmail.com>
 <20220410170127.058fc942@jic23-huawei>
In-Reply-To: <20220410170127.058fc942@jic23-huawei>
From:   Zheyu Ma <zheyuma97@gmail.com>
Date:   Mon, 11 Apr 2022 13:57:05 +0800
Message-ID: <CAMhUBjkctv-8kvGvdEt0nakyt9EXGwgzey=gQxYbesYrXbW6yQ@mail.gmail.com>
Subject: Re: [PATCH] iio: magnetometer: ak8975: Fix the error handling in ak8975_power_on()
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linus.walleij@linaro.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Apr 10, 2022 at 11:53 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat,  9 Apr 2022 11:48:49 +0800
> Zheyu Ma <zheyuma97@gmail.com> wrote:
>
> > When the driver fails to enable the regulator 'vid', we will get the
> > following splat:
> >
> > [   79.955610] WARNING: CPU: 5 PID: 441 at drivers/regulator/core.c:2257 _regulator_put+0x3ec/0x4e0
> > [   79.959641] RIP: 0010:_regulator_put+0x3ec/0x4e0
> > [   79.967570] Call Trace:
> > [   79.967773]  <TASK>
> > [   79.967951]  regulator_put+0x1f/0x30
> > [   79.968254]  devres_release_group+0x319/0x3d0
> > [   79.968608]  i2c_device_probe+0x766/0x940
> >
> > Fix this by disabling the 'vdd' regulator when failing to enable 'vid'
> > regulator.
> >
> > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> This driver doesn't really have a maintainer any more, though Linus W actually
> last touched this bit of code. So +CC.
>
> However, it's pretty obviously correct so applied to the fixes-togreg branch of iio.git.
>
> For future reference, please don't send one fix as reply to a fix on a different driver.
> Makes a mess of thread handling and tracking in patchwork etc.

Sorry for the confusion, I will take care of it next time.

> Ideally also please provide a fixes tag.  For this one I have applied with out it
> because it was a long time back and looks like the bug predates a bunch of refactoring
> of this code.

Thanks for your reminder, I will add the fixes tag in the next submission.

Regards,
Zheyu Ma