Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp596746pxb; Tue, 12 Apr 2022 08:52:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkH1HYedjsv0ri8O7XPX3u77DNMjq/3YPPBQsYo2IywhmaX1aqDK+WVEYRM0z5Qf8WObAn X-Received: by 2002:a65:5302:0:b0:39c:e41e:e8ff with SMTP id m2-20020a655302000000b0039ce41ee8ffmr20598677pgq.305.1649778747010; Tue, 12 Apr 2022 08:52:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649778747; cv=none; d=google.com; s=arc-20160816; b=vGigzAsRHPMH5lmmL1L6qp2NxCnYYx6ZWgFAxyjUkZiV0fqKAiv/2sZqMk8iSM03Kb wZyswQo+jnAgYpzU71LCYMhxHCEe1/XAG1DUugdrrYPfz6EawjlmrIh9+Dn1G3eF1cel 01GFe3k+ZUeo1il4ZQVuTCZ2sHh6AaligdMpXwOGZT937ljTGNCEtl5jNmzjDpIWIW1f yLvAD3qpKrtbB892JLKChFZ2cjoBBkVNolYP9I5Y3rnvbnG2xg+s83qe2gPTUPS0w85I 4d1+mlnv869ryAlz2eIyiH5Ed/UPvaUh/2PZYa2khhAhg+uP5VrBc8W43dpwea5GfCCX 46yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=AQYiTIlabf0XPtoPR35Y9NtmPHuTSnD6Vh/HNYD4peM=; b=aSADHWHlQWYbxsFM3qVk4lVPG1FxvniceeNyor6FnvRZ4GQDaBLh+I7Pxd2Asa5ARz dU0+cCaJnnUXbeNMQGUxBCe/8WJT8jsP4/a8Nt9lRdJ1EsNeV6XN2PT8LHjGcAMsUwBu UGfzPxCytn/YPKFYvTAwG6R3vdZmTIk5/l7jNlZ4tEmSjb2mtHRWXecqSc/tSCzhWo9W j63i3rjyqmaJ6R7d7eewxck1R43UcleUF1KsJHk0QlAZwXn1kCfokW0GKGl9b+VRVX16 /vUdwH70+mdx/q/Ka8eg1LSCmQf5Rxt0/fdLv+19L/FQr++Y6dlnUJ9pG5CEONt0f97X jjug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="hRp7dEi/"; dkim=neutral (no key) header.i=@suse.de header.b=ZAqAzxWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x75-20020a63314e000000b0039daab0bc0asi386948pgx.203.2022.04.12.08.52.11; Tue, 12 Apr 2022 08:52:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="hRp7dEi/"; dkim=neutral (no key) header.i=@suse.de header.b=ZAqAzxWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352591AbiDLJmt (ORCPT + 99 others); Tue, 12 Apr 2022 05:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377327AbiDLJer (ORCPT ); Tue, 12 Apr 2022 05:34:47 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0196A56432 for ; Tue, 12 Apr 2022 01:44:11 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C08A0210E3; Tue, 12 Apr 2022 08:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649753049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AQYiTIlabf0XPtoPR35Y9NtmPHuTSnD6Vh/HNYD4peM=; b=hRp7dEi/PsACelp54CQ1OBM6kEU8Gq6Tq7X0cezfJ0+DoyVl5/vae1o9Go+bJo8xo9hW3/ sZEIthWT8iIF3bNQroY/FyUGWNmFFYqrZ2g8rPfPOspll1zvi8v2lrAeupYrCIXzGW+xMr EA7bGKoKu+DS2mtMvDEnbYaT3dWYhsg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649753049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AQYiTIlabf0XPtoPR35Y9NtmPHuTSnD6Vh/HNYD4peM=; b=ZAqAzxWwTvuJtGRDX6871BgcbJJkKIBnnPUy470p68hDLtvLo5cRLxelCwTP25rlupgOpC R+qqaLav1sRsfJCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28E8E13780; Tue, 12 Apr 2022 08:44:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 31QQBtk7VWIUGwAAMHmgww (envelope-from ); Tue, 12 Apr 2022 08:44:09 +0000 Date: Tue, 12 Apr 2022 10:44:07 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, ying.huang@intel.com, songmuchun@bytedance.com, hch@infradead.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback Message-ID: References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409093500.10329-2-linmiaohe@huawei.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 09, 2022 at 05:34:52PM +0800, Miaohe Lin wrote: > The MADV_FREE pages check in folio_check_dirty_writeback is a bit hard to > follow. Add a comment to make the code clear. > > Suggested-by: Huang, Ying > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs