Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp597966pxb; Tue, 12 Apr 2022 08:54:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuxbwr0IjqD9QlRxOsP04HOZpCDSsf0aU5hxUJoS34jlQfXUWZ9eGa7/PzZh+jfmWX9So1 X-Received: by 2002:a17:90b:1d90:b0:1ca:9f55:3b78 with SMTP id pf16-20020a17090b1d9000b001ca9f553b78mr5773174pjb.38.1649778852843; Tue, 12 Apr 2022 08:54:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649778852; cv=none; d=google.com; s=arc-20160816; b=V4deL6a7TKHZVww051RgRuBNgQIOGLDf9Vq3RdyR9M721a88eHnuk2qK30i/Y4LhzP ndu1zJoaELU+6JFQXJDLpKLghtrDq7c+h8e1tYlVLqAB+H+1JjXb0+bK08soBcgT2Rn0 xic45t/iX/AYysz+8RAyyUf2euw7WTuzlEwM3Ei7V3VdvHPSKugoUv6yXZAJMsW5QJnS YDjrAM7G5OvW1Jadr23dHG0rGMEvWxPcj8rFB+Pj0pcCywKntFuBJ1eNoSOSDw/H7sKY QR75MxGH3sHLgoFHw5W0S59v2o5W94EWMHS9YWXjoHP7rYrtEb8oTgIXuqerhlZSo4Nd /bTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=guVtbfg9B3O42Dphm1hbldmCGDYWGez0fAfNeFikWjs=; b=jZSkbNPo7L5KcSNFhWhpdHI9DJ6SC3VoV4BdKEoQVo6tYvtSlcetHzvympLO9eaGTl a/6FXwozulkSi18WQz0GJZ16+vnmWpaWBQncHOtyGkYzR5RK9fAVGIvkN0Bfywsjti+Y wW8UUEUHR86Mvb0MvmP6hskJoKM1XZmqR2sekZP2zOATueajr+aFkXANEtp+PPq2BMNp zwXVdI/ZHap2mz/2nx6c1WG53Fw2b+Obe1uYcZG+q8W3hGDrnCTRf3h0quSwatkdzwvM 1/RLHUDO+viRpQMAsXE3swR2wq09jTDP6Jid5IdzmxWJi2vGl10FdDfuJVOYwomFjS1m akiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n16-20020a170902f61000b00156c21347b7si11772663plg.153.2022.04.12.08.53.57; Tue, 12 Apr 2022 08:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345968AbiDKMQ7 (ORCPT + 99 others); Mon, 11 Apr 2022 08:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241594AbiDKMQ4 (ORCPT ); Mon, 11 Apr 2022 08:16:56 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8614B40E62 for ; Mon, 11 Apr 2022 05:14:42 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndsw7-0003bV-RC; Mon, 11 Apr 2022 14:14:27 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ndsw6-002No1-JO; Mon, 11 Apr 2022 14:14:25 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ndsw4-002b3w-7w; Mon, 11 Apr 2022 14:14:24 +0200 Date: Mon, 11 Apr 2022 14:14:24 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Tony Lindgren Cc: Greg Kroah-Hartman , Andy Shevchenko , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Jiri Slaby , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Steffen Trumtrar Subject: Re: [PATCHv2] serial: 8250: Fix runtime PM for start_tx() for empty buffer Message-ID: <20220411121424.7pc3jjsqglxbfakt@pengutronix.de> References: <20220411111657.16744-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gesvtf2gmiko2n45" Content-Disposition: inline In-Reply-To: <20220411111657.16744-1-tony@atomide.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gesvtf2gmiko2n45 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2022 at 02:16:57PM +0300, Tony Lindgren wrote: > Commit 932d596378b0 ("serial: 8250: Return early in .start_tx() if there > are no chars to send") caused a regression where the drivers implementing > runtime PM stopped idling. This is because serial8250_rpm_put_tx() is now > unbalanced on early return, it normally gets called at __stop_tx(). >=20 > Fixes: 932d596378b0 ("serial: 8250: Return early in .start_tx() if there = are no chars to send") > Cc: Steffen Trumtrar > Cc: Uwe Kleine-K=F6nig > Signed-off-by: Tony Lindgren Reviewed-by: Uwe Kleine-K=F6nig Thanks for cleaning up behind me, Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --gesvtf2gmiko2n45 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmJUG50ACgkQwfwUeK3K 7AnyNQgAm9+Gx+Zu14wbYB/VB5sPoHur0onFhMVLygQZZ19CEy8drNGl3RlwEVgI XePEBiYTTPSIicfnlKt5iUJ3na0sw0a2P9cuusLA20Uh6wvJ0MBDWwtOqxNxANAT ruMELsGXugkGKuNUr4xZC03zaFMWEl7/iCHnZkDC+h/ZlNYQ94myvHKNxFD6BY/u fjCsGzty90/ymOqYnxcn4aDHd5l0LkWG5Et3qM+YfG73RyAx1tNyWWN55rW6dCWV BtEi4oVpj6NFJlR1egUDpr9Ezckj98YxTyYTK5bvBWsVtt3dy0KVoXDvDQ1Q+W4Q KxBkdQgC6J6iwrTdH3+zF/3O/hXA1A== =xXFf -----END PGP SIGNATURE----- --gesvtf2gmiko2n45--