Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Apr 2022 11:29:23 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Kevin Groeneveld <kgroeneveld@lenbrook.com>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Robin Gong <yibin.gong@nxp.com>, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts
Message-ID: <YlPDu3lu0rHJztNQ@matsya>
References: <20220406224809.29197-1-kgroeneveld@lenbrook.com>
 <YlBzQpWEqMHz/HsU@matsya>
 <3b26a4e2-93a8-8b3f-20c3-c1593ea0d48b@lenbrook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3b26a4e2-93a8-8b3f-20c3-c1593ea0d48b@lenbrook.com>
Precedence: bulk

Hi Kevin,

On 10-04-22, 18:28, Kevin Groeneveld wrote:
> On 2022-04-08 13:39, Vinod Koul wrote:
> > 1. Patch title should reflect the change introduced, so the title is not
> > apt, pls revise
> 
> In hindsight the title was not very descriptive. I will update and send a
> v2. Maybe something like:
> 
> dmaengine: imx-sdma: fix init of uart scripts
> 
> > 2. Is this in response to rmk's report, if so, please add reported-by
> 
> No. I am not even aware of any report on this issue. I discovered the issue
> on my own and found the problem commit by doing a bisect.

Okay I am adding Russell here to see if this fixes his issue as well..

> > 3. Lastly, I would like to see some tested by for this patch..
> 
> I have tested on imx5, imx6 and imx8 systems. I will add some brief details
> of this to the commit message in the v2 patch. I am not sure if I as the
> author should include a Tested-by tag.
> 
> > > Fixes: b98ce2f4e32b ("dmaengine: imx-sdma: add uart rom script")
> > 
> > cc: stable ?
> 
> That sounds reasonable. I am relatively new to submitting kernel patches and
> that thought never crossed by mind.

No worries, fixes should be backport to stable kernels, refer Documentation/process/stable-kernel-rules.rst

Thanks
-- 
~Vinod